mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Alexander Shiyan" <shc_work@mail.ru>
To: "Sascha Hauer" <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re[2]: [PATCH 6/6] ARM: Add relocatable binary support
Date: Tue, 05 Mar 2013 08:32:11 +0400	[thread overview]
Message-ID: <1362457931.500418774@f64.mail.ru> (raw)
In-Reply-To: <20130304201929.GI1906@pengutronix.de>

> On Tue, Mar 05, 2013 at 12:10:02AM +0400, Alexander Shiyan wrote:
> > > For making the same binary executable on different SoCs which have
> > > different DRAM addresses we have to be independent of the compile
> > > time link address.
> > > 
> > > This patch adds relocatable binary support for the ARM architecture.
> > > With this two new functions are available. relocate_to_current_adr
> > > will fixup the binary to continue executing from the current position.
> > > relocate_to_adr will copy the binary to a given address, fixup the
> > > binary and continue executing from there.
> > > 
> > > For the PBL and the real image relocatable support can be enabled
> > > independently. This is done to (hopefully) better cope with setups
> > > where the PBL runs from SRAM or ROM and the real binary does not.
> > > 
> > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > ...
> > 
> > Hello.
> > 
> > I just suggest put this new stuff under EXPERIMENTAL condition.
> > Thanks.
> 
> I'm unsure this makes sense. In the kernel currently 388 options depend
> on EXPERIMENTAL and 433 out of 438 defconfigs have EXPERIMENTAL enabled.
> This recently led to the discussion whether this option should be
> removed from the Kernel.

OK.

One more thing. You are introduce "RELOCATABLE" symbol in arm/Kconfig,
but symbol with same name is already exist in common/Kconfig. On
my opinion this is no so good.
Thanks.

---
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2013-03-05  4:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-04 20:03 [PATCH] " Sascha Hauer
2013-03-04 20:03 ` [PATCH 1/6] ARM: make cpu architecture detection available as static inline function Sascha Hauer
2013-03-04 20:46   ` Alexander Aring
2013-03-05 10:34     ` Sascha Hauer
2013-03-04 20:03 ` [PATCH 2/6] ARM: add early mmu cache flush function and use it in setup_c Sascha Hauer
2013-03-04 20:03 ` [PATCH 3/6] ARM: provide accessor functions for linker variables Sascha Hauer
2013-03-04 20:03 ` [PATCH 4/6] ARM boards: Use accessor functions to access " Sascha Hauer
2013-03-04 20:03 ` [PATCH 5/6] ARN: fixup vector addresses for relocatable binaries Sascha Hauer
2013-03-04 20:03 ` [PATCH 6/6] ARM: Add relocatable binary support Sascha Hauer
2013-03-04 20:10   ` Alexander Shiyan
2013-03-04 20:19     ` Sascha Hauer
2013-03-05  4:32       ` Alexander Shiyan [this message]
2013-03-05  7:25         ` Sascha Hauer
2013-03-04 20:53   ` Alexander Aring
2013-03-05 10:46     ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1362457931.500418774@f64.mail.ru \
    --to=shc_work@mail.ru \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox