* [PATCH] commands/tftp: use pr_debug for debug output
@ 2013-03-29 15:08 Hubert Feurstein
2013-03-29 16:32 ` Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 1 reply; 6+ messages in thread
From: Hubert Feurstein @ 2013-03-29 15:08 UTC (permalink / raw)
To: barebox
Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
---
commands/tftp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/commands/tftp.c b/commands/tftp.c
index 558b0ac..05d9d04 100644
--- a/commands/tftp.c
+++ b/commands/tftp.c
@@ -76,7 +76,7 @@ static int do_tftpb(int argc, char *argv[])
if (ret)
goto err_rmdir;
- printk("%s: %s -> %s\n", __func__, source, dest);
+ pr_debug("%s: %s -> %s\n", __func__, source, dest);
ret = copy_file(source, dest, 1);
--
1.8.1.3
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] commands/tftp: use pr_debug for debug output
2013-03-29 15:08 [PATCH] commands/tftp: use pr_debug for debug output Hubert Feurstein
@ 2013-03-29 16:32 ` Jean-Christophe PLAGNIOL-VILLARD
2013-03-30 10:50 ` Sascha Hauer
2013-04-02 8:07 ` [PATCH v2] commands/tftp: use debug() " Hubert Feurstein
0 siblings, 2 replies; 6+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2013-03-29 16:32 UTC (permalink / raw)
To: Hubert Feurstein; +Cc: barebox
On 16:08 Fri 29 Mar , Hubert Feurstein wrote:
> Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
> ---
> commands/tftp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/commands/tftp.c b/commands/tftp.c
> index 558b0ac..05d9d04 100644
> --- a/commands/tftp.c
> +++ b/commands/tftp.c
> @@ -76,7 +76,7 @@ static int do_tftpb(int argc, char *argv[])
> if (ret)
> goto err_rmdir;
>
> - printk("%s: %s -> %s\n", __func__, source, dest);
> + pr_debug("%s: %s -> %s\n", __func__, source, dest);
no pr_ is for device/driver not commands
use debug
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] commands/tftp: use pr_debug for debug output
2013-03-29 16:32 ` Jean-Christophe PLAGNIOL-VILLARD
@ 2013-03-30 10:50 ` Sascha Hauer
2013-03-30 12:46 ` Jean-Christophe PLAGNIOL-VILLARD
2013-04-02 8:07 ` [PATCH v2] commands/tftp: use debug() " Hubert Feurstein
1 sibling, 1 reply; 6+ messages in thread
From: Sascha Hauer @ 2013-03-30 10:50 UTC (permalink / raw)
To: Jean-Christophe PLAGNIOL-VILLARD; +Cc: barebox
On Fri, Mar 29, 2013 at 05:32:37PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 16:08 Fri 29 Mar , Hubert Feurstein wrote:
> > Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
> > ---
> > commands/tftp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/commands/tftp.c b/commands/tftp.c
> > index 558b0ac..05d9d04 100644
> > --- a/commands/tftp.c
> > +++ b/commands/tftp.c
> > @@ -76,7 +76,7 @@ static int do_tftpb(int argc, char *argv[])
> > if (ret)
> > goto err_rmdir;
> >
> > - printk("%s: %s -> %s\n", __func__, source, dest);
> > + pr_debug("%s: %s -> %s\n", __func__, source, dest);
> no pr_ is for device/driver not commands
Saying what he should use instead is probably very helpful.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] commands/tftp: use pr_debug for debug output
2013-03-30 10:50 ` Sascha Hauer
@ 2013-03-30 12:46 ` Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 0 replies; 6+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2013-03-30 12:46 UTC (permalink / raw)
To: Sascha Hauer; +Cc: barebox
On 11:50 Sat 30 Mar , Sascha Hauer wrote:
> On Fri, Mar 29, 2013 at 05:32:37PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 16:08 Fri 29 Mar , Hubert Feurstein wrote:
> > > Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
> > > ---
> > > commands/tftp.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/commands/tftp.c b/commands/tftp.c
> > > index 558b0ac..05d9d04 100644
> > > --- a/commands/tftp.c
> > > +++ b/commands/tftp.c
> > > @@ -76,7 +76,7 @@ static int do_tftpb(int argc, char *argv[])
> > > if (ret)
> > > goto err_rmdir;
> > >
> > > - printk("%s: %s -> %s\n", __func__, source, dest);
> > > + pr_debug("%s: %s -> %s\n", __func__, source, dest);
> > no pr_ is for device/driver not commands
>
> Saying what he should use instead is probably very helpful.
which I did
use debug
Best Regards,
J.
>
> Sascha
>
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] commands/tftp: use debug() for debug output
2013-03-29 16:32 ` Jean-Christophe PLAGNIOL-VILLARD
2013-03-30 10:50 ` Sascha Hauer
@ 2013-04-02 8:07 ` Hubert Feurstein
2013-04-03 7:11 ` Sascha Hauer
1 sibling, 1 reply; 6+ messages in thread
From: Hubert Feurstein @ 2013-04-02 8:07 UTC (permalink / raw)
To: barebox
Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
---
commands/tftp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/commands/tftp.c b/commands/tftp.c
index 558b0ac..c83d174 100644
--- a/commands/tftp.c
+++ b/commands/tftp.c
@@ -76,7 +76,7 @@ static int do_tftpb(int argc, char *argv[])
if (ret)
goto err_rmdir;
- printk("%s: %s -> %s\n", __func__, source, dest);
+ debug("%s: %s -> %s\n", __func__, source, dest);
ret = copy_file(source, dest, 1);
--
1.8.1.3
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] commands/tftp: use debug() for debug output
2013-04-02 8:07 ` [PATCH v2] commands/tftp: use debug() " Hubert Feurstein
@ 2013-04-03 7:11 ` Sascha Hauer
0 siblings, 0 replies; 6+ messages in thread
From: Sascha Hauer @ 2013-04-03 7:11 UTC (permalink / raw)
To: Hubert Feurstein; +Cc: barebox
On Tue, Apr 02, 2013 at 10:07:07AM +0200, Hubert Feurstein wrote:
> Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
Applied, thanks
Sascha
> ---
> commands/tftp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/commands/tftp.c b/commands/tftp.c
> index 558b0ac..c83d174 100644
> --- a/commands/tftp.c
> +++ b/commands/tftp.c
> @@ -76,7 +76,7 @@ static int do_tftpb(int argc, char *argv[])
> if (ret)
> goto err_rmdir;
>
> - printk("%s: %s -> %s\n", __func__, source, dest);
> + debug("%s: %s -> %s\n", __func__, source, dest);
>
> ret = copy_file(source, dest, 1);
>
> --
> 1.8.1.3
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-04-03 7:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-29 15:08 [PATCH] commands/tftp: use pr_debug for debug output Hubert Feurstein
2013-03-29 16:32 ` Jean-Christophe PLAGNIOL-VILLARD
2013-03-30 10:50 ` Sascha Hauer
2013-03-30 12:46 ` Jean-Christophe PLAGNIOL-VILLARD
2013-04-02 8:07 ` [PATCH v2] commands/tftp: use debug() " Hubert Feurstein
2013-04-03 7:11 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox