From: "Alexander Shiyan" <shc_work@mail.ru>
To: "Sascha Hauer" <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re[2]: [PATCH 2/2] ARM: i.MX: Update MX51 iomux definitions
Date: Tue, 09 Apr 2013 12:01:51 +0400 [thread overview]
Message-ID: <1365494511.379687833@f154.mail.ru> (raw)
In-Reply-To: <20130409073148.GE1906@pengutronix.de>
> > > On Sun, Apr 07, 2013 at 12:48:57PM +0400, Alexander Shiyan wrote:
> > > > The patch updates MX51 iomux definitions from kernel.
> > > >
> > > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > >
> > > This patch effectively reverts:
> > >
> > > commit 298d15571da8d1cb71e7fd87cc53cad3b2bf1d12
> > > Author: Eric Bénard <eric@eukrea.com>
> > > Date: Thu Sep 6 21:39:30 2012 +0200
> > >
> > > i.MX51: unbreak FEC iomux
> > >
> > > in commit 2bdc9f57a86dff41cfc1f87b644a2e53fdcce2b6 the iomux was synced
> > > with the kernel but this leads to some changes in the PAD_CTRL of some
> > > FEC pins leading to a non working FEC on our cpuimx51 board.
> > >
> > > This patch set back the PAD_CTRL of the missing pins to the initial
> > > value.
> > >
> > > Signed-off-by: Eric Bénard <eric@eukrea.com>
> > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > >
> > > You shouldn't do this.
> >
> > What about write a patch for the kernel for this?
>
> By the time I applied Erics patch I considered the days of the
> traditional iomux support in the kernel counted. From that day on
> we have to maintain our own versions anyway.
OK. Maybe as temporary solution we can define eukrea_cpuimx51 FEC
pins with NEW_PAD_CTRL macro? If so, I'll create a patch for this.
This will keep iomux-mx51.h file synced.
---
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-04-09 8:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-07 8:48 [PATCH 1/2] ARM: i.MX: Update MX2x " Alexander Shiyan
2013-04-07 8:48 ` [PATCH 2/2] ARM: i.MX: Update MX51 " Alexander Shiyan
2013-04-09 6:49 ` Sascha Hauer
2013-04-09 6:52 ` Re[2]: " Alexander Shiyan
2013-04-09 7:31 ` Sascha Hauer
2013-04-09 8:01 ` Alexander Shiyan [this message]
2013-04-09 8:03 ` Eric Bénard
2013-04-09 8:15 ` Re[2]: " Alexander Shiyan
2013-04-09 15:05 ` Alexander Shiyan
2013-04-12 10:36 ` Re[3]: " Alexander Shiyan
2013-04-12 17:26 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365494511.379687833@f154.mail.ru \
--to=shc_work@mail.ru \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox