From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH 4/7] memory commands: cleanup initialization
Date: Wed, 17 Apr 2013 13:39:05 +0200 [thread overview]
Message-ID: <1366198748-22717-5-git-send-email-s.hauer@pengutronix.de> (raw)
In-Reply-To: <1366198748-22717-1-git-send-email-s.hauer@pengutronix.de>
- return -ENOMEM instead of -1
- return the result of platform_driver_register
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
commands/mem.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/commands/mem.c b/commands/mem.c
index d48f92e..5bef3f7 100644
--- a/commands/mem.c
+++ b/commands/mem.c
@@ -567,15 +567,10 @@ static struct driver_d mem_drv = {
static int mem_init(void)
{
rw_buf = malloc(RW_BUF_SIZE);
- if(!rw_buf) {
- printf("%s: Out of memory\n", __FUNCTION__);
- return -1;
- }
+ if(!rw_buf)
+ return -ENOMEM;
add_mem_device("mem", 0, ~0, IORESOURCE_MEM_WRITEABLE);
- platform_driver_register(&mem_drv);
-
- return 0;
+ return platform_driver_register(&mem_drv);
}
-
device_initcall(mem_init);
--
1.8.2.rc2
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-04-17 11:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-17 11:39 [PATCH] memory commands Sascha Hauer
2013-04-17 11:39 ` [PATCH 1/7] memory commands: export common functions Sascha Hauer
2013-04-17 11:39 ` [PATCH 2/7] memory commands: move memory_display to separate file Sascha Hauer
2013-04-17 11:39 ` [PATCH 3/7] Use a common define for RW_BUF_SIZE Sascha Hauer
2013-04-17 11:39 ` Sascha Hauer [this message]
2013-04-17 11:39 ` [PATCH 5/7] memory commands: make rw_buf global Sascha Hauer
2013-04-17 11:39 ` [PATCH 6/7] memory commands: separate into one file per command Sascha Hauer
2013-04-17 11:39 ` [PATCH 7/7] Add memory modify command (mm) Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366198748-22717-5-git-send-email-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox