From: "Alexander Shiyan" <shc_work@mail.ru>
To: "Jean-Christophe PLAGNIOL-VILLARD" <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re[2]: [PATCH] GPIO: Add gpio_to_desc helper
Date: Sat, 11 May 2013 16:05:56 +0400 [thread overview]
Message-ID: <1368273956.326411741@f386.i.mail.ru> (raw)
In-Reply-To: <20130511113155.GE19265@game.jcrosoft.org>
> > > On 18:04 Fri 10 May , Alexander Shiyan wrote:
> > > > Patch adds gpio_to_desc helper for validate GPIO.
> > > > A bit optimization is performed (about -250 bytes on ARM).
> > > >
> > > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > > > ---
> > > > drivers/gpio/gpiolib.c | 97 ++++++++++++++++++++++++++------------------------
> > > > 1 file changed, 51 insertions(+), 46 deletions(-)
> > > >
> > > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> > > > index 6398268..d7aa094 100644
> > > > --- a/drivers/gpio/gpiolib.c
> > > > +++ b/drivers/gpio/gpiolib.c
> > > > @@ -32,20 +32,30 @@ static int gpio_ensure_requested(struct gpio_info *gi, int gpio)
> > > > return gpio_request(gpio, "gpio");
> > > > }
> > > >
> > > > +static struct gpio_info *gpio_to_desc(unsigned gpio)
> > > > +{
> > > > + if (!gpio_is_valid(gpio))
> > > put the WARN too as we need to known a gpio_xxx is used on a non valid gpio
> >
> > Original bb code does not contain any warnings here. So if it really
> > necessary it can be added later.
>
> put it as we keep the code inline with the kernel a key point for sync
And this warning avoid my second patch to remove checks when we are
call gpio_free/set/get etc... with non existent (optional) gpios.
I strongly do not want to add it.
---
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-05-11 12:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-10 14:04 Alexander Shiyan
2013-05-10 14:12 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-11 10:54 ` Re[2]: " Alexander Shiyan
2013-05-11 11:31 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-11 12:05 ` Alexander Shiyan [this message]
2013-05-11 14:38 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-11 14:46 ` Re[2]: " Alexander Shiyan
2013-05-11 14:50 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368273956.326411741@f386.i.mail.ru \
--to=shc_work@mail.ru \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox