mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] arm: mach-mvebu: drop useless clkdev.h
@ 2013-05-12 11:26 Thomas Petazzoni
  2013-05-13  8:19 ` Sascha Hauer
  0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2013-05-12 11:26 UTC (permalink / raw)
  To: barebox

As suggested by Antony Pavlov, get rid of the useless clkdev.h in
arch/arm/mach-mvebu/.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 arch/arm/mach-mvebu/include/mach/clkdev.h |    7 -------
 1 file changed, 7 deletions(-)
 delete mode 100644 arch/arm/mach-mvebu/include/mach/clkdev.h

diff --git a/arch/arm/mach-mvebu/include/mach/clkdev.h b/arch/arm/mach-mvebu/include/mach/clkdev.h
deleted file mode 100644
index 04b37a8..0000000
--- a/arch/arm/mach-mvebu/include/mach/clkdev.h
+++ /dev/null
@@ -1,7 +0,0 @@
-#ifndef __ASM_MACH_CLKDEV_H
-#define __ASM_MACH_CLKDEV_H
-
-#define __clk_get(clk) ({ 1; })
-#define __clk_put(clk) do { } while (0)
-
-#endif
-- 
1.7.9.5


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm: mach-mvebu: drop useless clkdev.h
  2013-05-12 11:26 [PATCH] arm: mach-mvebu: drop useless clkdev.h Thomas Petazzoni
@ 2013-05-13  8:19 ` Sascha Hauer
  2013-05-13  8:39   ` Thomas Petazzoni
  0 siblings, 1 reply; 5+ messages in thread
From: Sascha Hauer @ 2013-05-13  8:19 UTC (permalink / raw)
  To: Thomas Petazzoni; +Cc: barebox

On Sun, May 12, 2013 at 01:26:09PM +0200, Thomas Petazzoni wrote:
> As suggested by Antony Pavlov, get rid of the useless clkdev.h in
> arch/arm/mach-mvebu/.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Folded this into the original patch adding it.

Sascha

> ---
>  arch/arm/mach-mvebu/include/mach/clkdev.h |    7 -------
>  1 file changed, 7 deletions(-)
>  delete mode 100644 arch/arm/mach-mvebu/include/mach/clkdev.h
> 
> diff --git a/arch/arm/mach-mvebu/include/mach/clkdev.h b/arch/arm/mach-mvebu/include/mach/clkdev.h
> deleted file mode 100644
> index 04b37a8..0000000
> --- a/arch/arm/mach-mvebu/include/mach/clkdev.h
> +++ /dev/null
> @@ -1,7 +0,0 @@
> -#ifndef __ASM_MACH_CLKDEV_H
> -#define __ASM_MACH_CLKDEV_H
> -
> -#define __clk_get(clk) ({ 1; })
> -#define __clk_put(clk) do { } while (0)
> -
> -#endif
> -- 
> 1.7.9.5
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm: mach-mvebu: drop useless clkdev.h
  2013-05-13  8:19 ` Sascha Hauer
@ 2013-05-13  8:39   ` Thomas Petazzoni
  2013-05-13 11:53     ` Sascha Hauer
  0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2013-05-13  8:39 UTC (permalink / raw)
  To: Sascha Hauer; +Cc: barebox

Dear Sascha Hauer,

On Mon, 13 May 2013 10:19:07 +0200, Sascha Hauer wrote:
> On Sun, May 12, 2013 at 01:26:09PM +0200, Thomas Petazzoni wrote:
> > As suggested by Antony Pavlov, get rid of the useless clkdev.h in
> > arch/arm/mach-mvebu/.
> > 
> > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> 
> Folded this into the original patch adding it.

Just a development process question: since you're folding it, it means
that you're rebasing the 'next' branch constantly?

This sounds off for a public branch on top of which people might be
basing some more work, no?

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm: mach-mvebu: drop useless clkdev.h
  2013-05-13  8:39   ` Thomas Petazzoni
@ 2013-05-13 11:53     ` Sascha Hauer
  2013-05-13 12:11       ` Thomas Petazzoni
  0 siblings, 1 reply; 5+ messages in thread
From: Sascha Hauer @ 2013-05-13 11:53 UTC (permalink / raw)
  To: Thomas Petazzoni; +Cc: barebox

On Mon, May 13, 2013 at 10:39:24AM +0200, Thomas Petazzoni wrote:
> Dear Sascha Hauer,
> 
> On Mon, 13 May 2013 10:19:07 +0200, Sascha Hauer wrote:
> > On Sun, May 12, 2013 at 01:26:09PM +0200, Thomas Petazzoni wrote:
> > > As suggested by Antony Pavlov, get rid of the useless clkdev.h in
> > > arch/arm/mach-mvebu/.
> > > 
> > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > 
> > Folded this into the original patch adding it.
> 
> Just a development process question: since you're folding it, it means
> that you're rebasing the 'next' branch constantly?
> 
> This sounds off for a public branch on top of which people might be
> basing some more work, no?

You should normally be able to work on the master branch. If you have
dependencies to -next then yes, you would have to rebase which means
some work for you.
Not having a fast forward branch means that we have a better commit
history and that bugs noticed early enough do not even make it to the
master branch which increases bisectability significantly.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm: mach-mvebu: drop useless clkdev.h
  2013-05-13 11:53     ` Sascha Hauer
@ 2013-05-13 12:11       ` Thomas Petazzoni
  0 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2013-05-13 12:11 UTC (permalink / raw)
  To: Sascha Hauer; +Cc: barebox

Dear Sascha Hauer,

On Mon, 13 May 2013 13:53:22 +0200, Sascha Hauer wrote:

> You should normally be able to work on the master branch. If you have
> dependencies to -next then yes, you would have to rebase which means
> some work for you.
> Not having a fast forward branch means that we have a better commit
> history and that bugs noticed early enough do not even make it to the
> master branch which increases bisectability significantly.

Ok, good to know. Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2013-05-13 12:11 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-12 11:26 [PATCH] arm: mach-mvebu: drop useless clkdev.h Thomas Petazzoni
2013-05-13  8:19 ` Sascha Hauer
2013-05-13  8:39   ` Thomas Petazzoni
2013-05-13 11:53     ` Sascha Hauer
2013-05-13 12:11       ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox