Re[2]: [PATCH 1/1] Revert "nand_base: detect more ONFI flash"

From: "Alexander Shiyan" <shc_work@mail.ru>
To: "Eric Bénard" <eric@eukrea.com>
Cc: barebox@lists.infradead.org
Subject: Re[2]: [PATCH 1/1] Revert "nand_base: detect more ONFI flash"
Date: Wed, 15 May 2013 10:46:13 +0400	[thread overview]
Message-ID: <1368600373.828822510@f150.mail.ru> (raw)
In-Reply-To: <20130508182526.40de08c6@e6520eb>

> > > On Tue, May 07, 2013 at 10:21:39PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > >> this brake the nand support on at91sam9x5ek
> > >> where we have a non compliant ONFI nand
> > >> NAND device: Manufacturer ID: 0xad, Chip ID: 0xda (Hynix NAND 256MiB 3,3V 8-bit), 256MiB, page size: 2048, OOB size: 64
> > >> 
> > >> This reverts commit 4c2bdc8728016b3412523e3264651651fe752860.
> > > 
> > > Thank you for letting us know that this patch causes a regression for
> > > you. I this happens, please first try and fix the regression. If that
> > > doesn't work please tell us what about the original patch is so wrong
> > > that it needs to be reverted. With a good explanation it could be that
> > > someone else has an idea. And whatever you do, put the original author,
> > > Eric in this case, on Cc.
> > 
> > This commit was supposed just able to detect that a Nand is ONFI
> > 
> > but instead it brake supported Nand
> > 
> > So Eric can fix it but I've not time to debug this before 1 month
> > and the few platform that use ONFI are all busy
> > 
> > So as the commit just allow to detect a band is ONFI can we revert it
> > 
> > to keep non-ONFI Nand to work
> > 
> IIRC, I tested this patch on some i.MX board with non ONFI NAND flash
> and that worked fine unless I made a mistake in my tests which is
> always possible.
> 
> I've just sent a patch which may fix your problem, please give it a try
> (only compile tested, not tested on real hardware).

What is a patch to fix this? I've got some errors after update to latest master tree:

Board: ConnectCore i.MX51
detected i.MX51 revision 3.0
mmu: Error: Can't request SDRAM region for ttb
Error: Cannot request SDRAM region for stack
Module Variant: i.MX515@600MHz, PHY, Accel (0x0b)
Module HW Rev : 03
Module Serial : B111156789
mc13xxx-spi mc13xxx-spi0: Found MC13892 ID: 0x0045d0 [Rev: 2.0a]
nand: ONFI flash detected ... nand: ONFI param page 0 valid
nand: Manufacturer ID: 0x2c, Chip ID: 0xda (Micron MT29F2G08AAD), page size: 2048, OOB size: 64
BUG: failure at arch/arm/cpu/mmu.c:122/find_pte()!
BUG!
no stack data available

---
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox