* [PATCH] tegra: fix off-by-one array boundary checking for uart_id_to_base
@ 2013-06-04 1:43 Axel Lin
0 siblings, 0 replies; only message in thread
From: Axel Lin @ 2013-06-04 1:43 UTC (permalink / raw)
To: Sascha Hauer; +Cc: barebox
id is used as array subscript, so it's valid value range is 0 ... ARRAY_SIZE -1.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
arch/arm/mach-tegra/include/mach/lowlevel.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-tegra/include/mach/lowlevel.h b/arch/arm/mach-tegra/include/mach/lowlevel.h
index b7c01c0..361b12e 100644
--- a/arch/arm/mach-tegra/include/mach/lowlevel.h
+++ b/arch/arm/mach-tegra/include/mach/lowlevel.h
@@ -136,7 +136,7 @@ static inline long tegra20_get_debuguart_base(void)
return 0;
id = (odmdata & T20_ODMDATA_UARTID_MASK) >> T20_ODMDATA_UARTID_SHIFT;
- if (id > ARRAY_SIZE(uart_id_to_base))
+ if (id >= ARRAY_SIZE(uart_id_to_base))
return 0;
return uart_id_to_base[id];
--
1.8.1.2
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2013-06-04 1:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-04 1:43 [PATCH] tegra: fix off-by-one array boundary checking for uart_id_to_base Axel Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox