From: "Alexander Shiyan" <shc_work@mail.ru>
To: "Lucas Stach" <l.stach@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] Revert "usb: chipidea-imx: Fix usb initialization"
Date: Wed, 05 Jun 2013 17:33:55 +0400 [thread overview]
Message-ID: <1370439235.553989759@f166.mail.ru> (raw)
In-Reply-To: <1370438768-13729-1-git-send-email-l.stach@pengutronix.de>
> This breaks HSIC and has no good justification why this would
> be needed for ULPI.
>
> This reverts commit 2e7d66f526217f6ff3167e4580aecb9548a0de33.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> drivers/usb/imx/chipidea-imx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/imx/chipidea-imx.c b/drivers/usb/imx/chipidea-imx.c
> index 928ebf3..4ee7610 100644
> --- a/drivers/usb/imx/chipidea-imx.c
> +++ b/drivers/usb/imx/chipidea-imx.c
> @@ -148,13 +148,13 @@ static int imx_chipidea_probe(struct device_d *dev)
> ci->data.post_init = imx_chipidea_port_post_init;
> ci->data.drvdata = ci;
>
> + imx_chipidea_port_init(ci);
> +
> portsc = readl(base + 0x184);
> portsc &= ~MXC_EHCI_PORTSC_MASK;
> portsc |= ci->flags & MXC_EHCI_PORTSC_MASK;
> writel(portsc, base + 0x184);
>
> - imx_chipidea_port_init(ci);
> -
> if ((ci->flags & MXC_EHCI_PORTSC_MASK) == MXC_EHCI_MODE_ULPI) {
> dev_dbg(dev, "using ULPI phy\n");
> if (IS_ENABLED(CONFIG_USB_ULPI)) {
This order was be before driver rework. Unfortunately I can not check right now,
but when I test initial version, it was be a proper order, at least for pcm038 (imx27 module).
---
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-06-05 13:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 13:26 Lucas Stach
2013-06-05 13:33 ` Alexander Shiyan [this message]
2013-06-05 20:20 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370439235.553989759@f166.mail.ru \
--to=shc_work@mail.ru \
--cc=barebox@lists.infradead.org \
--cc=l.stach@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox