From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: barebox@lists.infradead.org
Subject: [PATCH v2 17/22] OF: base: introduce property write for bool, u8, u16, and u64
Date: Wed, 19 Jun 2013 11:09:46 +0200 [thread overview]
Message-ID: <1371632991-1504-18-git-send-email-sebastian.hesselbarth@gmail.com> (raw)
In-Reply-To: <1371576607-8090-1-git-send-email-sebastian.hesselbarth@gmail.com>
This adds functions to set an array of or a single value for bool,
u8, u16, and u64 properties.
Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
---
Cc: barebox@lists.infradead.org
---
drivers/of/base.c | 156 +++++++++++++++++++++++++++++++++++++++++++++++++++++
include/of.h | 82 ++++++++++++++++++++++++----
2 files changed, 227 insertions(+), 11 deletions(-)
diff --git a/drivers/of/base.c b/drivers/of/base.c
index 1c385c8..bf73acb 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -798,6 +798,119 @@ int of_property_count_strings(struct device_node *np, const char *propname)
EXPORT_SYMBOL_GPL(of_property_count_strings);
/**
+ * of_property_write_bool - Create/Delete empty (bool) property.
+ *
+ * @np: device node from which the property is to be set.
+ * @propname: name of the property to be set.
+ *
+ * Search for a property in a device node and create or delete the property.
+ * If the property already exists and write value is false, the property is
+ * deleted. If write value is true and the property does not exist, it is
+ * created. Returns 0 on success, -ENOMEM if the property or array
+ * of elements cannot be created.
+ */
+int of_property_write_bool(struct device_node *np, const char *propname,
+ const bool value)
+{
+ struct property *prop = of_find_property(np, propname, NULL);
+
+ if (!value) {
+ if (prop)
+ of_delete_property(prop);
+ return 0;
+ }
+
+ if (!prop)
+ prop = of_new_property(np, propname, NULL, 0);
+ if (!prop)
+ return -ENOMEM;
+
+ return 0;
+}
+
+/**
+ * of_property_write_u8_array - Write an array of u8 to a property. If
+ * the property does not exist, it will be created and appended to the given
+ * device node.
+ *
+ * @np: device node to which the property value is to be written.
+ * @propname: name of the property to be written.
+ * @values: pointer to array elements to write.
+ * @sz: number of array elements to write.
+ *
+ * Search for a property in a device node and write 8-bit value(s) to
+ * it. If the property does not exist, it will be created and appended to
+ * the device node. Returns 0 on success, -ENOMEM if the property or array
+ * of elements cannot be created.
+ */
+int of_property_write_u8_array(struct device_node *np,
+ const char *propname, const u8 *values,
+ size_t sz)
+{
+ struct property *prop = of_find_property(np, propname, NULL);
+ u8 *val;
+
+ if (!prop)
+ prop = of_new_property(np, propname, NULL, 0);
+ if (!prop)
+ return -ENOMEM;
+
+ free(prop->value);
+
+ prop->length = sizeof(*val) * sz;
+ prop->value = malloc(prop->length);
+ if (!prop->value)
+ return -ENOMEM;
+
+ val = prop->value;
+ while (sz--)
+ *val++ = *values++;
+
+ return 0;
+}
+
+/**
+ * of_property_write_u16_array - Write an array of u16 to a property. If
+ * the property does not exist, it will be created and appended to the given
+ * device node.
+ *
+ * @np: device node to which the property value is to be written.
+ * @propname: name of the property to be written.
+ * @values: pointer to array elements to write.
+ * @sz: number of array elements to write.
+ *
+ * Search for a property in a device node and write 16-bit value(s) to
+ * it. If the property does not exist, it will be created and appended to
+ * the device node. Returns 0 on success, -ENOMEM if the property or array
+ * of elements cannot be created.
+ */
+int of_property_write_u16_array(struct device_node *np,
+ const char *propname, const u16 *values,
+ size_t sz)
+{
+ struct property *prop = of_find_property(np, propname, NULL);
+ __be16 *val;
+
+ if (!prop)
+ prop = of_new_property(np, propname, NULL, 0);
+ if (!prop)
+ return -ENOMEM;
+
+ free(prop->value);
+
+ prop->length = sizeof(*val) * sz;
+ prop->value = malloc(prop->length);
+ if (!prop->value)
+ return -ENOMEM;
+
+ val = prop->value;
+ while (sz--)
+ *val++ = cpu_to_be16(*values++);
+
+ return 0;
+}
+
+/**
* of_property_write_u32_array - Write an array of u32 to a property. If
* the property does not exist, it will be created and appended to the given
* device node.
@@ -839,6 +952,49 @@ int of_property_write_u32_array(struct device_node *np,
}
/**
+ * of_property_write_u64_array - Write an array of u64 to a property. If
+ * the property does not exist, it will be created and appended to the given
+ * device node.
+ *
+ * @np: device node to which the property value is to be written.
+ * @propname: name of the property to be written.
+ * @values: pointer to array elements to write.
+ * @sz: number of array elements to write.
+ *
+ * Search for a property in a device node and write 64-bit value(s) to
+ * it. If the property does not exist, it will be created and appended to
+ * the device node. Returns 0 on success, -ENOMEM if the property or array
+ * of elements cannot be created.
+ */
+int of_property_write_u64_array(struct device_node *np,
+ const char *propname, const u64 *values,
+ size_t sz)
+{
+ struct property *prop = of_find_property(np, propname, NULL);
+ __be32 *val;
+
+ if (!prop)
+ prop = of_new_property(np, propname, NULL, 0);
+ if (!prop)
+ return -ENOMEM;
+
+ free(prop->value);
+
+ prop->length = 2 * sizeof(*val) * sz;
+ prop->value = malloc(prop->length);
+ if (!prop->value)
+ return -ENOMEM;
+
+ val = prop->value;
+ while (sz--) {
+ of_write_number(val, *values++, 2);
+ val += 2;
+ }
+
+ return 0;
+}
+
+/**
* of_parse_phandle - Resolve a phandle property to a device_node pointer
* @np: Pointer to device node holding phandle property
* @phandle_name: Name of property holding a phandle value
diff --git a/include/of.h b/include/of.h
index e03bd40..6abd906 100644
--- a/include/of.h
+++ b/include/of.h
@@ -113,17 +113,6 @@ static inline void of_write_number(void *__cell, u64 val, int size)
}
}
-int of_property_write_u32_array(struct device_node *np,
- const char *propname, const u32 *values,
- size_t sz);
-
-static inline int of_property_write_u32(struct device_node *np,
- const char *propname,
- u32 value)
-{
- return of_property_write_u32_array(np, propname, &value, 1);
-}
-
const void *of_get_property(const struct device_node *np, const char *name,
int *lenp);
@@ -218,6 +207,21 @@ extern int of_property_match_string(struct device_node *np,
extern int of_property_count_strings(struct device_node *np,
const char *propname);
+extern int of_property_write_bool(struct device_node *np,
+ const char *propname, const bool value);
+extern int of_property_write_u8_array(struct device_node *np,
+ const char *propname, const u8 *values,
+ size_t sz);
+extern int of_property_write_u16_array(struct device_node *np,
+ const char *propname, const u16 *values,
+ size_t sz);
+extern int of_property_write_u32_array(struct device_node *np,
+ const char *propname, const u32 *values,
+ size_t sz);
+extern int of_property_write_u64_array(struct device_node *np,
+ const char *propname, const u64 *values,
+ size_t sz);
+
extern struct device_node *of_parse_phandle(const struct device_node *np,
const char *phandle_name,
int index);
@@ -359,6 +363,36 @@ static inline int of_property_count_strings(struct device_node *np,
return -ENOSYS;
}
+static inline int of_property_write_bool(struct device_node *np,
+ const char *propname, const bool value)
+{
+ return -ENOSYS;
+}
+
+static inline int of_property_write_u8_array(struct device_node *np,
+ const char *propname, const u8 *values, size_t sz)
+{
+ return -ENOSYS;
+}
+
+static inline int of_property_write_u16_array(struct device_node *np,
+ const char *propname, const u16 *values, size_t sz)
+{
+ return -ENOSYS;
+}
+
+static inline int of_property_write_u32_array(struct device_node *np,
+ const char *propname, const u32 *values, size_t sz)
+{
+ return -ENOSYS;
+}
+
+static inline int of_property_write_u64_array(struct device_node *np,
+ const char *propname, const u64 *values, size_t sz)
+{
+ return -ENOSYS;
+}
+
static inline struct device_node *of_parse_phandle(const struct device_node *np,
const char *phandle_name, int index)
{
@@ -502,4 +536,30 @@ static inline int of_property_read_u32(const struct device_node *np,
return of_property_read_u32_array(np, propname, out_value, 1);
}
+static inline int of_property_write_u8(struct device_node *np,
+ const char *propname, u8 value)
+{
+ return of_property_write_u8_array(np, propname, &value, 1);
+}
+
+static inline int of_property_write_u16(struct device_node *np,
+ const char *propname, u16 value)
+{
+ return of_property_write_u16_array(np, propname, &value, 1);
+}
+
+static inline int of_property_write_u32(struct device_node *np,
+ const char *propname,
+ u32 value)
+{
+ return of_property_write_u32_array(np, propname, &value, 1);
+}
+
+static inline int of_property_write_u64(struct device_node *np,
+ const char *propname,
+ u64 value)
+{
+ return of_property_write_u64_array(np, propname, &value, 1);
+}
+
#endif /* __OF_H */
--
1.7.2.5
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-06-19 9:10 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 17:29 [PATCH 00/22] Barebox OF API fixes, sync, and cleanup Sebastian Hesselbarth
2013-06-18 17:29 ` [PATCH 01/22] lib: string: import case-insensitive string compare Sebastian Hesselbarth
2013-06-18 17:29 ` [PATCH 02/22] OF: base: bail out early on missing matches for of_match_node Sebastian Hesselbarth
2013-06-18 17:29 ` [PATCH 03/22] OF: base: also update property length on of_property_write_u32 Sebastian Hesselbarth
2013-06-18 17:29 ` [PATCH 04/22] OF: base: export of_alias_scan Sebastian Hesselbarth
2013-06-18 17:29 ` [PATCH 05/22] OF: base: convert strcmp to default string compare functions Sebastian Hesselbarth
2013-06-18 17:29 ` [PATCH 06/22] OF: base: sync of_find_property with linux OF API Sebastian Hesselbarth
2013-06-18 17:29 ` [PATCH 07/22] OF: base: sync of_find_node_by_path " Sebastian Hesselbarth
2013-06-18 20:13 ` Sascha Hauer
2013-06-18 20:19 ` Sebastian Hesselbarth
2013-06-18 17:29 ` [PATCH 08/22] OF: base: rename of_node_disabled to of_device_is_available Sebastian Hesselbarth
2013-06-18 17:29 ` [PATCH 09/22] OF: base: import of_find_node_by_name from Linux OF API Sebastian Hesselbarth
2013-06-18 17:29 ` [PATCH 10/22] OF: base: import of_find_compatible_node " Sebastian Hesselbarth
2013-06-18 17:29 ` [PATCH 11/22] OF: base: import of_find_matching_node_and_match " Sebastian Hesselbarth
2013-06-18 17:29 ` [PATCH 12/22] OF: base: import of_find_node_with_property " Sebastian Hesselbarth
2013-06-18 17:29 ` [PATCH 13/22] OF: base: import parent/child functions " Sebastian Hesselbarth
2013-06-18 20:18 ` Sascha Hauer
2013-06-18 20:29 ` Sascha Hauer
2013-06-18 20:34 ` Sebastian Hesselbarth
2013-06-18 17:29 ` [PATCH 14/22] OF: base: import of_property_read_* helpers " Sebastian Hesselbarth
2013-06-18 17:30 ` [PATCH 15/22] OF: base: import of_parse_phandle " Sebastian Hesselbarth
2013-06-18 17:30 ` [PATCH 16/22] OF: base: import parse phandle functions " Sebastian Hesselbarth
2013-06-18 17:30 ` [PATCH 17/22] OF: base: introduce property write for bool, u8, u16, and u64 Sebastian Hesselbarth
2013-06-18 17:30 ` [PATCH 18/22] OF: base: import property iterators from Linux OF API Sebastian Hesselbarth
2013-06-18 17:30 ` [PATCH 19/22] OF: base: remove of_tree_for_each_node from public API Sebastian Hesselbarth
2013-06-18 17:30 ` [PATCH 20/22] OF: base: remove of_find_child_by_name Sebastian Hesselbarth
2013-06-18 17:30 ` [PATCH 21/22] OF: base: convert and remove device_node_for_nach_child Sebastian Hesselbarth
2013-06-18 17:30 ` [PATCH 22/22] OF: base: cleanup base function include Sebastian Hesselbarth
2013-06-19 9:09 ` [PATCH v2 00/22] Barebox OF API fixes, sync, and cleanup Sebastian Hesselbarth
2013-06-20 9:18 ` Sascha Hauer
2013-06-19 9:09 ` [PATCH v2 01/22] lib: string: import case-insensitive string compare Sebastian Hesselbarth
2013-06-20 9:04 ` Sascha Hauer
2013-06-19 9:09 ` [PATCH v2 02/22] OF: base: bail out early on missing matches for of_match_node Sebastian Hesselbarth
2013-06-19 9:09 ` [PATCH v2 03/22] OF: base: also update property length on of_property_write_u32 Sebastian Hesselbarth
2013-06-19 9:09 ` [PATCH v2 04/22] OF: base: export of_alias_scan Sebastian Hesselbarth
2013-06-19 9:09 ` [PATCH v2 05/22] OF: base: convert strcmp to default string compare functions Sebastian Hesselbarth
2013-06-19 9:09 ` [PATCH v2 06/22] OF: base: sync of_find_property with linux OF API Sebastian Hesselbarth
2013-06-20 8:57 ` Sascha Hauer
2013-06-19 9:09 ` [PATCH v2 07/22] OF: base: sync of_find_node_by_path " Sebastian Hesselbarth
2013-06-19 9:09 ` [PATCH v2 08/22] OF: base: rename of_node_disabled to of_device_is_available Sebastian Hesselbarth
2013-06-19 9:09 ` [PATCH v2 09/22] OF: base: import of_find_node_by_name from Linux OF API Sebastian Hesselbarth
2013-06-19 9:09 ` [PATCH v2 10/22] OF: base: import of_find_compatible_node " Sebastian Hesselbarth
2013-06-19 9:09 ` [PATCH v2 11/22] OF: base: import of_find_matching_node_and_match " Sebastian Hesselbarth
2013-06-19 9:09 ` [PATCH v2 12/22] OF: base: import of_find_node_with_property " Sebastian Hesselbarth
2013-06-19 9:09 ` [PATCH v2 13/22] OF: base: import parent/child functions " Sebastian Hesselbarth
2013-06-19 9:09 ` [PATCH v2 14/22] OF: base: import of_property_read_* helpers " Sebastian Hesselbarth
2013-06-19 9:09 ` [PATCH v2 15/22] OF: base: import of_parse_phandle " Sebastian Hesselbarth
2013-06-19 9:09 ` [PATCH v2 16/22] OF: base: import parse phandle functions " Sebastian Hesselbarth
2013-06-20 8:33 ` Sascha Hauer
2013-06-19 9:09 ` Sebastian Hesselbarth [this message]
2013-06-19 9:09 ` [PATCH v2 18/22] OF: base: import property iterators " Sebastian Hesselbarth
2013-06-19 9:09 ` [PATCH v2 19/22] OF: base: remove of_tree_for_each_node from public API Sebastian Hesselbarth
2013-06-19 9:09 ` [PATCH v2 20/22] OF: base: remove of_find_child_by_name Sebastian Hesselbarth
2013-06-19 9:09 ` [PATCH v2 21/22] OF: base: convert and remove device_node_for_nach_child Sebastian Hesselbarth
2013-06-19 9:09 ` [PATCH v2 22/22] OF: base: cleanup base function include Sebastian Hesselbarth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371632991-1504-18-git-send-email-sebastian.hesselbarth@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox