From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: barebox@lists.infradead.org
Subject: [PATCH v3 07/10] OF: base: remove dead device related functions
Date: Tue, 2 Jul 2013 20:14:36 +0200 [thread overview]
Message-ID: <1372788879-11028-8-git-send-email-sebastian.hesselbarth@gmail.com> (raw)
In-Reply-To: <1372152047-28134-1-git-send-email-sebastian.hesselbarth@gmail.com>
With recent conversion to of_platfrom_populate_some functions are now
dead code and can be removed.
Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
---
Cc: barebox@lists.infradead.org
---
drivers/of/base.c | 183 -----------------------------------------------------
1 files changed, 0 insertions(+), 183 deletions(-)
diff --git a/drivers/of/base.c b/drivers/of/base.c
index eb9ac84..9d63127 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -1543,94 +1543,6 @@ int of_set_property(struct device_node *np, const char *name, const void *val, i
return 0;
}
-static struct device_d *add_of_amba_device(struct device_node *node)
-{
- struct amba_device *dev;
- char *name, *at;
-
- dev = xzalloc(sizeof(*dev));
-
- name = xstrdup(node->name);
- at = strchr(name, '@');
- if (at) {
- *at = 0;
- snprintf(dev->dev.name, MAX_DRIVER_NAME, "%s.%s", at + 1, name);
- } else {
- strncpy(dev->dev.name, node->name, MAX_DRIVER_NAME);
- }
-
- dev->dev.id = DEVICE_ID_SINGLE;
- memcpy(&dev->res, &node->resource[0], sizeof(struct resource));
- dev->dev.resource = node->resource;
- dev->dev.num_resources = 1;
- dev->dev.device_node = node;
- node->device = &dev->dev;
-
- of_property_read_u32(node, "arm,primecell-periphid", &dev->periphid);
-
- debug("register device 0x%08x\n", node->resource[0].start);
-
- amba_device_add(dev);
-
- free(name);
-
- return &dev->dev;
-}
-
-static struct device_d *add_of_platform_device(struct device_node *node,
- struct device_d *parent)
-{
- struct device_d *dev;
- char *name, *at;
-
- dev = xzalloc(sizeof(*dev));
-
- dev->parent = parent;
-
- name = xstrdup(node->name);
- at = strchr(name, '@');
- if (at) {
- *at = 0;
- snprintf(dev->name, MAX_DRIVER_NAME, "%s.%s", at + 1, name);
- } else {
- strncpy(dev->name, node->name, MAX_DRIVER_NAME);
- }
-
- dev->id = DEVICE_ID_SINGLE;
- dev->resource = node->resource;
- dev->num_resources = node->num_resource;
- dev->device_node = node;
- node->device = dev;
-
- debug("register device 0x%08x\n", node->resource[0].start);
-
- platform_device_register(dev);
-
- free(name);
-
- return dev;
-}
-
-static struct device_d *add_of_device(struct device_node *node,
- struct device_d *parent)
-{
- const struct property *cp;
-
- if (!of_device_is_available(node))
- return NULL;
-
- cp = of_get_property(node, "compatible", NULL);
- if (!cp)
- return NULL;
-
- if (IS_ENABLED(CONFIG_ARM_AMBA) &&
- of_device_is_compatible(node, "arm,primecell") == 1)
- return add_of_amba_device(node);
- else
- return add_of_platform_device(node, parent);
-}
-EXPORT_SYMBOL(add_of_device);
-
static u64 dt_mem_next_cell(int s, const __be32 **cellp)
{
const __be32 *p = *cellp;
@@ -1678,82 +1590,6 @@ int of_add_memory(struct device_node *node, bool dump)
return 0;
}
-static struct device_d *add_of_device_resource(struct device_node *node,
- struct device_d *parent)
-{
- u64 address = 0, size;
- struct resource *res, *resp;
- struct device_d *dev;
- const __be32 *endp, *reg;
- const char *resname;
- int na, nc, n_resources;
- int ret, len, index;
-
- reg = of_get_property(node, "reg", &len);
- if (!reg)
- return add_of_device(node, parent);
-
- of_bus_count_cells(node, &na, &nc);
-
- n_resources = (len / sizeof(__be32)) / (na + nc);
-
- res = resp = xzalloc(sizeof(*res) * n_resources);
-
- endp = reg + (len / sizeof(__be32));
-
- index = 0;
-
- while ((endp - reg) >= (na + nc)) {
- address = of_translate_address(node, reg);
- if (address == OF_BAD_ADDR) {
- ret = -EINVAL;
- goto err_free;
- }
-
- reg += na;
- size = dt_mem_next_cell(nc, ®);
-
- resp->start = address;
- resp->end = address + size - 1;
- resname = NULL;
- of_property_read_string_index(node, "reg-names", index, &resname);
- if (resname)
- resp->name = xstrdup(resname);
- resp->flags = IORESOURCE_MEM;
- resp++;
- index++;
- }
-
- /*
- * A device may already be registered as platform_device.
- * Instead of registering the same device again, just
- * add this node to the existing device.
- */
- for_each_device(dev) {
- if (!dev->resource)
- continue;
- if (dev->resource->start == res->start &&
- dev->resource->end == res->end) {
- debug("connecting %s to %s\n", node->name, dev_name(dev));
- node->device = dev;
- dev->device_node = node;
- node->resource = dev->resource;
- ret = 0;
- goto err_free;
- }
- }
-
- node->resource = res;
- node->num_resource = n_resources;
-
- return add_of_device(node, parent);
-
-err_free:
- free(res);
-
- return NULL;
-}
-
void of_free(struct device_node *node)
{
struct device_node *n, *nt;
@@ -1787,25 +1623,6 @@ void of_free(struct device_node *node)
of_set_root_node(NULL);
}
-static void __of_probe(struct device_node *node,
- const struct of_device_id *matches,
- struct device_d *parent)
-{
- struct device_node *n;
- struct device_d *dev;
-
- if (node->device)
- return;
-
- dev = add_of_device_resource(node, parent);
-
- if (!of_match_node(matches, node))
- return;
-
- list_for_each_entry(n, &node->children, parent_list)
- __of_probe(n, matches, dev);
-}
-
static void __of_parse_phandles(struct device_node *node)
{
struct device_node *n;
--
1.7.2.5
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-07-02 18:15 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-25 9:20 [PATCH 0/9] OF: address and device related sync and cleanup Sebastian Hesselbarth
2013-06-25 9:20 ` [PATCH 1/9] OF: import address related functions from Linux OF API Sebastian Hesselbarth
2013-06-25 9:20 ` [PATCH 2/9] OF: convert of_translate_address to new API Sebastian Hesselbarth
2013-06-25 9:20 ` [PATCH 3/9] OF: base: move OF_ROOT_NODE_ defines to local OF code Sebastian Hesselbarth
2013-06-25 9:20 ` [PATCH 4/9] OF: import bus/device related functions from Linux OF API Sebastian Hesselbarth
2013-06-25 12:55 ` Sebastian Hesselbarth
2013-06-26 6:11 ` Sascha Hauer
2013-06-26 8:23 ` Sebastian Hesselbarth
2013-06-26 8:43 ` [PATCH v2 " Sebastian Hesselbarth
2013-06-25 9:20 ` [PATCH 5/9] OF: base: use of_platform_populate for probing Sebastian Hesselbarth
2013-06-29 14:22 ` Sascha Hauer
2013-06-25 9:20 ` [PATCH 6/9] OF: base: remove dead device related functions Sebastian Hesselbarth
2013-06-25 9:20 ` [PATCH 7/9] OF: remove device and resource pointer from struct device_node Sebastian Hesselbarth
2013-06-29 14:28 ` Sascha Hauer
2013-06-29 14:31 ` Sascha Hauer
2013-06-29 16:03 ` Sebastian Hesselbarth
2013-06-29 16:09 ` Sascha Hauer
2013-06-25 9:20 ` [PATCH 8/9] OF: base: convert of_add_memory to OF API Sebastian Hesselbarth
2013-06-25 19:48 ` Sascha Hauer
2013-06-25 19:57 ` Sebastian Hesselbarth
2013-06-25 21:38 ` Sebastian Hesselbarth
2013-06-26 8:43 ` [PATCH v2 " Sebastian Hesselbarth
2013-06-25 9:20 ` [PATCH 9/9] OF: base: rename of_free to of_delete_node Sebastian Hesselbarth
2013-06-27 6:51 ` [PATCH 0/9] OF: address and device related sync and cleanup Sascha Hauer
2013-06-27 7:50 ` Sebastian Hesselbarth
2013-06-27 8:58 ` Sascha Hauer
2013-06-27 9:00 ` Sebastian Hesselbarth
2013-06-27 18:19 ` Sascha Hauer
2013-06-27 18:27 ` Sebastian Hesselbarth
2013-07-02 18:14 ` [PATCH v3 00/10] " Sebastian Hesselbarth
2013-07-05 6:45 ` Sascha Hauer
2013-07-02 18:14 ` [PATCH v3 01/10] OF: import address related functions from Linux OF API Sebastian Hesselbarth
2013-07-02 18:14 ` [PATCH v3 02/10] OF: convert of_translate_address to new API Sebastian Hesselbarth
2013-07-02 18:14 ` [PATCH v3 03/10] OF: base: move OF_ROOT_NODE_ defines to local OF code Sebastian Hesselbarth
2013-07-02 18:14 ` [PATCH v3 04/10] OF: import bus/device related functions from Linux OF API Sebastian Hesselbarth
2013-07-02 18:14 ` [PATCH v3 05/10] OF: gpio: convert DT based gpio handling to new " Sebastian Hesselbarth
2013-07-02 18:14 ` [PATCH v3 06/10] OF: base: use of_platform_populate for probing Sebastian Hesselbarth
2013-07-02 18:14 ` Sebastian Hesselbarth [this message]
2013-07-02 18:14 ` [PATCH v3 08/10] OF: remove device and resource pointer from struct device_node Sebastian Hesselbarth
2013-07-02 18:14 ` [PATCH v3 09/10] OF: base: convert of_add_memory to OF API Sebastian Hesselbarth
2013-07-02 18:14 ` [PATCH v3 10/10] OF: base: rename of_free to of_delete_node Sebastian Hesselbarth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372788879-11028-8-git-send-email-sebastian.hesselbarth@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox