From: "Alexander Shiyan" <shc_work@mail.ru>
To: "Sascha Hauer" <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 7/8] Set model and hostname at boardlevel
Date: Thu, 15 Aug 2013 11:39:20 +0400 [thread overview]
Message-ID: <1376552360.905287029@f384.i.mail.ru> (raw)
In-Reply-To: <1376551741-16438-8-git-send-email-s.hauer@pengutronix.de>
> With multiboard support the compiletime generated BOARDINFO string
> gets more and more meaningless. This removes it from Kconfig and
> replaces it with a variable that can be set at boardlevel.
>
> Also many boards have a standard setting for the hostname in the
> environment. This patch also moves the standard to C code by calling
> barebox_set_hostname().
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
[...]
> diff --git a/arch/arm/boards/ccxmx51/ccxmx51.c b/arch/arm/boards/ccxmx51/ccxmx51.c
> index 2485e12..57280d5 100644
> --- a/arch/arm/boards/ccxmx51/ccxmx51.c
> +++ b/arch/arm/boards/ccxmx51/ccxmx51.c
> @@ -475,6 +475,9 @@ static int ccxmx51_console_init(void)
> {
> mxc_iomux_v3_setup_multiple_pads(ccxmx51_pads, ARRAY_SIZE(ccxmx51_pads));
>
> + barebox_set_model("Digi ConnectCore i.MX51");
> + barebox_set_hostname("cccmx51");
Not a fatal, but please remove one "c" during commit ;)
Thanks.
---
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-08-15 7:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-15 7:28 [PATCH] move BOARDINFO to globalvar Sascha Hauer
2013-08-15 7:28 ` [PATCH 1/8] globalvar: Allow to set initial value Sascha Hauer
2013-08-15 7:28 ` [PATCH 2/8] Add a global.version variable Sascha Hauer
2013-08-15 7:28 ` [PATCH 3/8] globalvar: move globalvar init to pure_initcall Sascha Hauer
2013-08-15 7:28 ` [PATCH 4/8] remove remaining references of CONFIG_BOARDINFO Sascha Hauer
2013-08-15 7:28 ` [PATCH 5/8] introduce barebox_set_model Sascha Hauer
2013-08-15 7:28 ` [PATCH 6/8] Make hostname available to C Code Sascha Hauer
2013-08-15 7:29 ` [PATCH 7/8] Set model and hostname at boardlevel Sascha Hauer
2013-08-15 7:39 ` Alexander Shiyan [this message]
2013-08-15 9:13 ` Sascha Hauer
2013-08-15 9:07 ` Sebastian Hesselbarth
2013-08-15 9:13 ` Sascha Hauer
2013-08-15 9:19 ` Sebastian Hesselbarth
2013-08-15 7:29 ` [PATCH 8/8] export model as globalvar Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376552360.905287029@f384.i.mail.ru \
--to=shc_work@mail.ru \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox