mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH 06/11] globalvar: Do not modify already existing variables
Date: Fri, 27 Sep 2013 08:47:37 +0200	[thread overview]
Message-ID: <1380264462-27614-7-git-send-email-s.hauer@pengutronix.de> (raw)
In-Reply-To: <1380264462-27614-1-git-send-email-s.hauer@pengutronix.de>

When globalvar_add_simple was called on previously existing variables
then the value was overwritten, even when value was passed as NULL.
Do not overwrite the value in this case which allows us to do a 'global'
on the same variable multiple times without loosing the values.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 common/globalvar.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/common/globalvar.c b/common/globalvar.c
index edb66dd..abd1270 100644
--- a/common/globalvar.c
+++ b/common/globalvar.c
@@ -72,6 +72,9 @@ int globalvar_add_simple(const char *name, const char *value)
 	if (ret && ret != -EEXIST)
 		return ret;
 
+	if (!value)
+		return 0;
+
 	return dev_set_param(&global_device, name, value);
 }
 
-- 
1.8.4.rc3


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2013-09-27  6:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-27  6:47 misc patches Sascha Hauer
2013-09-27  6:47 ` [PATCH 01/11] ARM: pfla02: Fix compiler warning Sascha Hauer
2013-09-27  6:47 ` [PATCH 02/11] detect command: Add missing help text for -a option Sascha Hauer
2013-09-27  6:47 ` [PATCH 03/11] ata: ide-sff: Add missing wait for ready in write function Sascha Hauer
2013-09-27  6:47 ` [PATCH 04/11] move devinfo command to its own file Sascha Hauer
2013-09-27  6:47 ` [PATCH 05/11] usb: Turn some printf into pr_* Sascha Hauer
2013-09-27  6:47 ` Sascha Hauer [this message]
2013-09-27  6:47 ` [PATCH 07/11] scripts/Makefile: cleanup Sascha Hauer
2013-09-27  6:47 ` [PATCH 08/11] scripts/Makefile: implement targetprogs-y Sascha Hauer
2013-09-27  6:47 ` [PATCH 09/11] scripts: Move omap4_usbboot to its own directory Sascha Hauer
2013-09-27  6:47 ` [PATCH 10/11] bootm needs uImage support. Select it Sascha Hauer
2013-09-27  6:47 ` [PATCH 11/11] defenv-2: Do not overwrite previously existing global variables Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1380264462-27614-7-git-send-email-s.hauer@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox