From: Lucas Stach <l.stach@pengutronix.de>
To: Andre Heider <a.heider@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: rpi: fix reading of the EMMC clock for CONFIG_MMU
Date: Wed, 16 Oct 2013 09:32:09 +0200 [thread overview]
Message-ID: <1381908729.4093.12.camel@weser.hi.pengutronix.de> (raw)
In-Reply-To: <1381858703-27993-2-git-send-email-a.heider@gmail.com>
Am Dienstag, den 15.10.2013, 19:38 +0200 schrieb Andre Heider:
> Add explicit flushing to prevent the 50MHz fallback.
>
Uh, this is pretty ugly. We certainly don't want all those explicit
invalidates/flushes in the driver code. Isn't it possible to push this
into some helper functions, that do the right thing when communicating
with the mailboxes?
> Signed-off-by: Andre Heider <a.heider@gmail.com>
> ---
> drivers/mci/mci-bcm2835.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mci/mci-bcm2835.c b/drivers/mci/mci-bcm2835.c
> index a0c364d..2ffdeec 100644
> --- a/drivers/mci/mci-bcm2835.c
> +++ b/drivers/mci/mci-bcm2835.c
> @@ -28,6 +28,7 @@
> * Author: Wilhelm Lundgren <wilhelm.lundgren@cybercom.com>
> */
>
> +#include <asm/mmu.h>
> #include <common.h>
> #include <init.h>
> #include <mci.h>
> @@ -471,7 +472,7 @@ int bcm2835_mci_reset(struct mci_host *mci, struct device_d *mci_dev)
> static u32 bcm2835_mci_get_emmc_clock(struct msg_get_clock_rate *clk_data)
> {
> u32 val;
> - struct bcm2835_mbox_regs *regs =
> + struct bcm2835_mbox_regs __iomem *regs =
> (struct bcm2835_mbox_regs *) BCM2835_MBOX_PHYSADDR;
>
> /*Read out old msg*/
> @@ -489,6 +490,7 @@ static u32 bcm2835_mci_get_emmc_clock(struct msg_get_clock_rate *clk_data)
> break;
> }
> val = BCM2835_MBOX_PROP_CHAN + ((u32) &clk_data->hdr);
> + dma_flush_range((u32)clk_data, (u32)clk_data + sizeof(*clk_data));
> writel(val, ®s->write);
>
> while (true) {
> @@ -504,6 +506,9 @@ static u32 bcm2835_mci_get_emmc_clock(struct msg_get_clock_rate *clk_data)
> if ((val & 0x0F) == BCM2835_MBOX_PROP_CHAN)
> break;
> }
> +
> + dma_inv_range((u32)clk_data, (u32)clk_data + sizeof(*clk_data));
> +
> if ((val & ~0x0F) == ((u32) &clk_data->hdr))
> if (clk_data->get_clock_rate.tag_hdr.val_len
> & BCM2835_MBOX_TAG_VAL_LEN_RESPONSE)
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-5076 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-10-16 7:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 17:38 Andre Heider
2013-10-16 7:32 ` Lucas Stach [this message]
2013-10-16 9:00 ` Andre Heider
2013-10-16 7:37 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381908729.4093.12.camel@weser.hi.pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=a.heider@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox