From: Andre Heider <a.heider@gmail.com>
To: barebox@lists.infradead.org
Subject: [PATCH 09/10] mci: bcm2835: use the registered device clkdev
Date: Sat, 19 Oct 2013 14:20:54 +0200 [thread overview]
Message-ID: <1382185254-29183-8-git-send-email-a.heider@gmail.com> (raw)
In-Reply-To: <1382185130-28995-1-git-send-email-a.heider@gmail.com>
Switch from local mailbox code to using the newly created clock device.
Signed-off-by: Andre Heider <a.heider@gmail.com>
---
drivers/mci/mci-bcm2835.c | 93 ++++++++++-------------------------------------
drivers/mci/mci-bcm2835.h | 48 ------------------------
2 files changed, 19 insertions(+), 122 deletions(-)
diff --git a/drivers/mci/mci-bcm2835.c b/drivers/mci/mci-bcm2835.c
index 2ffdeec..7d8997c 100644
--- a/drivers/mci/mci-bcm2835.c
+++ b/drivers/mci/mci-bcm2835.c
@@ -28,13 +28,14 @@
* Author: Wilhelm Lundgren <wilhelm.lundgren@cybercom.com>
*/
-#include <asm/mmu.h>
#include <common.h>
#include <init.h>
#include <mci.h>
#include <io.h>
#include <malloc.h>
#include <clock.h>
+#include <linux/clk.h>
+
#include "mci-bcm2835.h"
#include "sdhci.h"
@@ -469,53 +470,6 @@ int bcm2835_mci_reset(struct mci_host *mci, struct device_d *mci_dev)
return bcm2835_mci_wait_command_done(host);
}
-static u32 bcm2835_mci_get_emmc_clock(struct msg_get_clock_rate *clk_data)
-{
- u32 val;
- struct bcm2835_mbox_regs __iomem *regs =
- (struct bcm2835_mbox_regs *) BCM2835_MBOX_PHYSADDR;
-
- /*Read out old msg*/
- while (true) {
- val = readl(®s->status);
- if (val & BCM2835_MBOX_STATUS_RD_EMPTY)
- break;
- val = readl(®s->read);
- }
-
- /*Check for ok to write*/
- while (true) {
- val = readl(®s->status);
- if (!(val & BCM2835_MBOX_STATUS_WR_FULL))
- break;
- }
- val = BCM2835_MBOX_PROP_CHAN + ((u32) &clk_data->hdr);
- dma_flush_range((u32)clk_data, (u32)clk_data + sizeof(*clk_data));
- writel(val, ®s->write);
-
- while (true) {
- /* Wait for the response */
- while (true) {
- val = readl(®s->status);
- if (!(val & BCM2835_MBOX_STATUS_RD_EMPTY))
- break;
- }
-
- /* Read the response */
- val = readl(®s->read);
- if ((val & 0x0F) == BCM2835_MBOX_PROP_CHAN)
- break;
- }
-
- dma_inv_range((u32)clk_data, (u32)clk_data + sizeof(*clk_data));
-
- if ((val & ~0x0F) == ((u32) &clk_data->hdr))
- if (clk_data->get_clock_rate.tag_hdr.val_len
- & BCM2835_MBOX_TAG_VAL_LEN_RESPONSE)
- return 1;
- return 0;
-}
-
static int bcm2835_mci_detect(struct device_d *dev)
{
struct bcm2835_mci_host *host = dev->priv;
@@ -526,7 +480,22 @@ static int bcm2835_mci_detect(struct device_d *dev)
static int bcm2835_mci_probe(struct device_d *hw_dev)
{
struct bcm2835_mci_host *host;
- struct msg_get_clock_rate *clk_data;
+ static struct clk *clk;
+ int ret;
+
+ clk = clk_get(hw_dev, NULL);
+ if (IS_ERR(clk)) {
+ ret = PTR_ERR(clk);
+ dev_err(hw_dev, "clock not found: %d\n", ret);
+ return ret;
+ }
+
+ ret = clk_enable(clk);
+ if (ret) {
+ dev_err(hw_dev, "clock failed to enable: %d\n", ret);
+ clk_put(clk);
+ return ret;
+ }
host = xzalloc(sizeof(*host));
host->mci.send_cmd = bcm2835_mci_request;
@@ -534,31 +503,7 @@ static int bcm2835_mci_probe(struct device_d *hw_dev)
host->mci.init = bcm2835_mci_reset;
host->mci.hw_dev = hw_dev;
host->hw_dev = hw_dev;
-
- /* Allocate a buffer thats 16 bytes aligned in memory
- * Of the 32 bits address passed into the mbox 28 bits
- * are the address of the buffer, lower 4 bits is channel
- */
- clk_data = memalign(16, sizeof(struct msg_get_clock_rate));
- memset(clk_data, 0, sizeof(struct msg_get_clock_rate));
- clk_data->hdr.buf_size = sizeof(struct msg_get_clock_rate);
- clk_data->get_clock_rate.tag_hdr.tag = BCM2835_MBOX_TAG_GET_CLOCK_RATE;
- clk_data->get_clock_rate.tag_hdr.val_buf_size =
- sizeof(clk_data->get_clock_rate.body);
- clk_data->get_clock_rate.tag_hdr.val_len =
- sizeof(clk_data->get_clock_rate.body.req);
- clk_data->get_clock_rate.body.req.clock_id = BCM2835_MBOX_CLOCK_ID_EMMC;
-
- if (!bcm2835_mci_get_emmc_clock(clk_data)) {
- dev_warn(host->hw_dev,
- "Failed getting emmc clock, lets go anyway with 50MHz\n");
- host->max_clock = 50000000;
- } else {
- host->max_clock = clk_data->get_clock_rate.body.resp.rate_hz;
- dev_info(host->hw_dev, "Got emmc clock at %d Hz\n",
- host->max_clock);
- }
-
+ host->max_clock = clk_get_rate(clk);
host->regs = dev_request_mem_region(hw_dev, 0);
if (host->regs == NULL) {
dev_err(host->hw_dev, "Failed request mem region, aborting...\n");
diff --git a/drivers/mci/mci-bcm2835.h b/drivers/mci/mci-bcm2835.h
index 4158a18..2c95e03 100644
--- a/drivers/mci/mci-bcm2835.h
+++ b/drivers/mci/mci-bcm2835.h
@@ -23,51 +23,3 @@
#define MAX_CLK_DIVIDER_V3 2046
#define MAX_CLK_DIVIDER_V2 256
-
-/*this is only for mbox comms*/
-#define BCM2835_MBOX_PHYSADDR 0x2000b880
-#define BCM2835_MBOX_TAG_GET_CLOCK_RATE 0x00030002
-#define BCM2835_MBOX_CLOCK_ID_EMMC 1
-#define BCM2835_MBOX_STATUS_WR_FULL 0x80000000
-#define BCM2835_MBOX_STATUS_RD_EMPTY 0x40000000
-#define BCM2835_MBOX_PROP_CHAN 8
-#define BCM2835_MBOX_TAG_VAL_LEN_RESPONSE 0x80000000
-
-struct bcm2835_mbox_regs {
- u32 read;
- u32 rsvd0[5];
- u32 status;
- u32 config;
- u32 write;
-};
-
-
-struct bcm2835_mbox_hdr {
- u32 buf_size;
- u32 code;
-};
-
-struct bcm2835_mbox_tag_hdr {
- u32 tag;
- u32 val_buf_size;
- u32 val_len;
-};
-
-struct bcm2835_mbox_tag_get_clock_rate {
- struct bcm2835_mbox_tag_hdr tag_hdr;
- union {
- struct {
- u32 clock_id;
- } req;
- struct {
- u32 clock_id;
- u32 rate_hz;
- } resp;
- } body;
-};
-
-struct msg_get_clock_rate {
- struct bcm2835_mbox_hdr hdr;
- struct bcm2835_mbox_tag_get_clock_rate get_clock_rate;
- u32 end_tag;
-};
--
1.8.3.2
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-10-19 12:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-19 12:18 [PATCH 00/10] RPi mailbox support Andre Heider
2013-10-19 12:18 ` [PATCH 01/10] ARM: cache: restore cache functions from the PBL Andre Heider
2013-10-19 12:20 ` [PATCH 02/10] ARM: cache: do not crash when the MMU isn't yet setup Andre Heider
2013-10-19 12:20 ` [PATCH 03/10] common: add a macro to align an array on the stack Andre Heider
2013-10-19 12:20 ` [PATCH 04/10] ARM: bcm2835: cleanup clock registering Andre Heider
2013-10-19 12:20 ` [PATCH 05/10] ARM: bcm2835: register the clocksource driver earlier Andre Heider
2013-10-19 12:20 ` [PATCH 06/10] ARM: bcm2835: register the clocksource device earlier Andre Heider
2013-10-19 12:20 ` [PATCH 07/10] ARM: bcm2835: add a mailbox driver for VideoCore Andre Heider
2013-10-19 12:20 ` [PATCH 08/10] ARM: rpi: register a clkdev for the eMMC clock Andre Heider
2013-10-19 12:20 ` Andre Heider [this message]
2013-10-19 12:21 ` [PATCH 10/10] ARM: rpi: use the proper ARM memory size Andre Heider
2013-10-21 8:46 ` [PATCH 00/10] RPi mailbox support Sascha Hauer
2013-10-21 15:32 ` Andre Heider
2013-10-22 13:34 ` Sascha Hauer
2013-10-22 16:57 ` Andre Heider
2013-10-22 21:37 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382185254-29183-8-git-send-email-a.heider@gmail.com \
--to=a.heider@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox