mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Alexander Shiyan" <shc_work@mail.ru>
To: "Sascha Hauer" <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] console: Obey "linux, stdout-path" parameter regardless of CONSOLE_ACTIVATE_XX
Date: Sat, 26 Oct 2013 07:38:01 +0400	[thread overview]
Message-ID: <1382758681.49092736@f414.i.mail.ru> (raw)
In-Reply-To: <20131025235741.GE30088@pengutronix.de>

> On Fri, Oct 25, 2013 at 07:23:48PM +0400, Alexander Shiyan wrote:
> > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > ---
> >  common/console.c  |  4 ++--
> >  drivers/of/base.c | 13 ++++---------
> >  include/of.h      |  2 +-
> >  3 files changed, 7 insertions(+), 12 deletions(-)
...
> Can you elaborate why you need this patch? Normally on devicetree based
> boards I set CONSOLE_ACTIVATE_NONE. In this case I think your patch
> changes nothing. If you set CONSOLE_ACTIVATE_ALL or
> CONSOLE_ACTIVATE_FIRST your patch seems to overwrite the Kconfig setting
> with the devicetree setting. Why don't you set CONSOLE_ACTIVATE_NONE in
> the first place?

You are right. Lets forget this patch.

---
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2013-10-26  3:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-25 15:23 Alexander Shiyan
2013-10-25 23:57 ` Sascha Hauer
2013-10-26  3:38   ` Alexander Shiyan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1382758681.49092736@f414.i.mail.ru \
    --to=shc_work@mail.ru \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox