[PATCH] pinctrl: don't allow drivers to be selected by menuconfig user

[PATCH] pinctrl: don't allow drivers to be selected by menuconfig user

[Lucas Stach]

There is no much sense in having the pinctrl drivers be user selectable
as all arches using on of them already selects the right one.

So to avoid presenting the user with the choice to enable unrelated
pinctrl drivers or pushing lots of dependencies into the Kconfig just
drop the configurability.

Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 drivers/pinctrl/Kconfig | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 0b859b8..58397a0 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -1,5 +1,3 @@
-menu "Pin controllers"
-
 config PINCTRL
 	bool "Pin controller core support"
 	depends on OFDEVICE
@@ -10,25 +8,23 @@ config PINCTRL
 	  support but instead provide their own SoC specific APIs
 
 config PINCTRL_IMX_IOMUX_V1
-	bool "i.MX iomux v1"
+	bool
 	help
 	  This iomux controller is found on i.MX1,21,27.
 
 config PINCTRL_IMX_IOMUX_V2
-	bool "i.MX iomux v2"
+	bool
 	help
 	  This iomux controller is found on i.MX31.
 
 config PINCTRL_IMX_IOMUX_V3
 	select PINCTRL if OFDEVICE
-	bool "i.MX iomux v3"
+	bool
 	help
 	  This iomux controller is found on i.MX25,35,51,53,6.
 
 config PINCTRL_TEGRA20
 	select PINCTRL
-	bool "Tegra 20 pinmux"
+	bool
 	help
 	  The pinmux controller found on the Tegra 20 line of SoCs.
-
-endmenu
-- 
1.8.4.rc3


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] pinctrl: don't allow drivers to be selected by menuconfig user

[Sascha Hauer]

On Wed, Oct 30, 2013 at 12:06:28PM +0100, Lucas Stach wrote:
> There is no much sense in having the pinctrl drivers be user selectable
> as all arches using on of them already selects the right one.
> 
> So to avoid presenting the user with the choice to enable unrelated
> pinctrl drivers or pushing lots of dependencies into the Kconfig just
> drop the configurability.
> 
> Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>

Applied, thanks

Sascha

> ---
>  drivers/pinctrl/Kconfig | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index 0b859b8..58397a0 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -1,5 +1,3 @@
> -menu "Pin controllers"
> -
>  config PINCTRL
>  	bool "Pin controller core support"
>  	depends on OFDEVICE
> @@ -10,25 +8,23 @@ config PINCTRL
>  	  support but instead provide their own SoC specific APIs
>  
>  config PINCTRL_IMX_IOMUX_V1
> -	bool "i.MX iomux v1"
> +	bool
>  	help
>  	  This iomux controller is found on i.MX1,21,27.
>  
>  config PINCTRL_IMX_IOMUX_V2
> -	bool "i.MX iomux v2"
> +	bool
>  	help
>  	  This iomux controller is found on i.MX31.
>  
>  config PINCTRL_IMX_IOMUX_V3
>  	select PINCTRL if OFDEVICE
> -	bool "i.MX iomux v3"
> +	bool
>  	help
>  	  This iomux controller is found on i.MX25,35,51,53,6.
>  
>  config PINCTRL_TEGRA20
>  	select PINCTRL
> -	bool "Tegra 20 pinmux"
> +	bool
>  	help
>  	  The pinmux controller found on the Tegra 20 line of SoCs.
> -
> -endmenu
> -- 
> 1.8.4.rc3
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox