From: "Alexander Shiyan" <shc_work@mail.ru>
To: "Sascha Hauer" <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org,
"Rostislav Lisovy" <lisovy@gmail.com>,
pisa@cmp.felk.cvut.cz
Subject: Re: [PATCH 2/3] ARM: i.mx53: Parse Reset GPIO pin in FEC driver from Devicetree
Date: Fri, 22 Nov 2013 13:34:11 +0400 [thread overview]
Message-ID: <1385112851.747276864@f131.i.mail.ru> (raw)
In-Reply-To: <20131122070907.GH24559@pengutronix.de>
> On Wed, Nov 20, 2013 at 10:22:25PM +0100, Rostislav Lisovy wrote:
> > Signed-off-by: Rostislav Lisovy <lisovy@gmail.com>
> >
> > diff --git a/drivers/net/fec_imx.c b/drivers/net/fec_imx.c
...
> > + phy_reset = of_get_named_gpio(dev->device_node, "phy-reset-gpios", 0);
> > + if (!gpio_is_valid(phy_reset)) {
> > + dev_info(dev, "'phy-reset' gpio is not valid\n");
>
> Applied this series, but dropped this message. The problem with these
> kind of messages is that now nearly all i.MX users start seeing it and
> wonder if this is something they have to care about.
"phy-reset-duration" property should be handled together with "phy-reset-gpios"-property.
Additionally, the reset level is hardcoded to "0", but should be taken from
2nd cell GPIO DT definition.
I am not sure about 2nd issue, but the first can be implemented very easy.
---
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-11-22 9:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 21:22 [PATCH 0/3 v3] Support for Voipac X53-DMM-668 module and Voipac Baseboard Rostislav Lisovy
2013-11-20 21:22 ` [PATCH 1/3] ARM: dts: i.mx53: Internal keyboard controller + i2c pinmux Rostislav Lisovy
2013-11-20 21:22 ` [PATCH 2/3] ARM: i.mx53: Parse Reset GPIO pin in FEC driver from Devicetree Rostislav Lisovy
2013-11-22 7:09 ` Sascha Hauer
2013-11-22 9:34 ` Alexander Shiyan [this message]
2013-11-20 21:22 ` [PATCH 3/3] ARM: i.mx53: Support for Voipac board with X53-DMM-668 module Rostislav Lisovy
-- strict thread matches above, loose matches on Subject: below --
2013-11-12 22:46 [PATCH 0/3 v2] Support for Voipac X53-DMM-668 module and Voipac Baseboard Rostislav Lisovy
2013-11-12 22:46 ` [PATCH 2/3] ARM: i.mx53: Parse Reset GPIO pin in FEC driver from Devicetree Rostislav Lisovy
2013-11-13 10:35 ` Sascha Hauer
2013-11-05 14:42 [PATCH 0/3] Support for Voipac X53-DMM-668 module and Voipac Baseboard Rostislav Lisovy
2013-11-05 14:42 ` [PATCH 2/3] ARM: i.mx53: Parse Reset GPIO pin in FEC driver from Devicetree Rostislav Lisovy
2013-11-05 16:15 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-05 19:11 ` Pavel Pisa
2013-11-06 8:39 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385112851.747276864@f131.i.mail.ru \
--to=shc_work@mail.ru \
--cc=barebox@lists.infradead.org \
--cc=lisovy@gmail.com \
--cc=pisa@cmp.felk.cvut.cz \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox