* [PATCH] serial: add missing depends on ARCH_ZYNQ
@ 2013-12-04 23:28 Alexander Aring
2013-12-06 9:07 ` Steffen Trumtrar
0 siblings, 1 reply; 5+ messages in thread
From: Alexander Aring @ 2013-12-04 23:28 UTC (permalink / raw)
To: barebox
The cadence serial driver is some ARCH_ZYNQ specific driver.
Add a depends on ARCH_ZYNQ for this driver.
Signed-off-by: Alexander Aring <alex.aring@gmail.com>
---
drivers/serial/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
index 11fc155..d520dda 100644
--- a/drivers/serial/Kconfig
+++ b/drivers/serial/Kconfig
@@ -119,6 +119,7 @@ config DRIVER_SERIAL_OMAP4_USBBOOT
config DRIVER_SERIAL_CADENCE
bool "Cadence UART driver"
+ depends on ARCH_ZYNQ
help
Say Y here if you have a Cadence serial IP core.
--
1.8.4.2
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] serial: add missing depends on ARCH_ZYNQ
2013-12-04 23:28 [PATCH] serial: add missing depends on ARCH_ZYNQ Alexander Aring
@ 2013-12-06 9:07 ` Steffen Trumtrar
2013-12-06 11:59 ` Alexander Aring
2013-12-09 7:24 ` Alexander Aring
0 siblings, 2 replies; 5+ messages in thread
From: Steffen Trumtrar @ 2013-12-06 9:07 UTC (permalink / raw)
To: Alexander Aring; +Cc: barebox
Hi!
On Thu, Dec 05, 2013 at 12:28:11AM +0100, Alexander Aring wrote:
> The cadence serial driver is some ARCH_ZYNQ specific driver.
> Add a depends on ARCH_ZYNQ for this driver.
>
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> ---
> drivers/serial/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
> index 11fc155..d520dda 100644
> --- a/drivers/serial/Kconfig
> +++ b/drivers/serial/Kconfig
> @@ -119,6 +119,7 @@ config DRIVER_SERIAL_OMAP4_USBBOOT
>
> config DRIVER_SERIAL_CADENCE
> bool "Cadence UART driver"
> + depends on ARCH_ZYNQ
> help
> Say Y here if you have a Cadence serial IP core.
>
> --
> 1.8.4.2
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
Does is not compile with other archs?
This is intended to be a generic driver; Zynq just happens to be the only user.
-> It should not depend on ARCH_ZYNQ.
Regards,
Steffen
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] serial: add missing depends on ARCH_ZYNQ
2013-12-06 9:07 ` Steffen Trumtrar
@ 2013-12-06 11:59 ` Alexander Aring
2013-12-06 12:18 ` Alexander Aring
2013-12-09 7:24 ` Alexander Aring
1 sibling, 1 reply; 5+ messages in thread
From: Alexander Aring @ 2013-12-06 11:59 UTC (permalink / raw)
To: Steffen Trumtrar; +Cc: barebox
Hi Steffen,
On Fri, Dec 06, 2013 at 10:07:32AM +0100, Steffen Trumtrar wrote:
> Hi!
>
> On Thu, Dec 05, 2013 at 12:28:11AM +0100, Alexander Aring wrote:
> > The cadence serial driver is some ARCH_ZYNQ specific driver.
> > Add a depends on ARCH_ZYNQ for this driver.
> >
> > Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> > ---
> > drivers/serial/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
> > index 11fc155..d520dda 100644
> > --- a/drivers/serial/Kconfig
> > +++ b/drivers/serial/Kconfig
> > @@ -119,6 +119,7 @@ config DRIVER_SERIAL_OMAP4_USBBOOT
> >
> > config DRIVER_SERIAL_CADENCE
> > bool "Cadence UART driver"
> > + depends on ARCH_ZYNQ
> > help
> > Say Y here if you have a Cadence serial IP core.
> >
> > --
> > 1.8.4.2
> >
> >
> > _______________________________________________
> > barebox mailing list
> > barebox@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/barebox
> >
>
> Does is not compile with other archs?
> This is intended to be a generic driver; Zynq just happens to be the only user.
> -> It should not depend on ARCH_ZYNQ.
oh, I first figure out a depends on COMMON_CLK was missing and though
that this driver is a platform specific driver.
When it's a generic driver we should add a "depends on COMMON_CLK"
because there are some generic clock api calls.
- Alex
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] serial: add missing depends on ARCH_ZYNQ
2013-12-06 11:59 ` Alexander Aring
@ 2013-12-06 12:18 ` Alexander Aring
0 siblings, 0 replies; 5+ messages in thread
From: Alexander Aring @ 2013-12-06 12:18 UTC (permalink / raw)
To: Steffen Trumtrar; +Cc: barebox
On Fri, Dec 06, 2013 at 12:59:55PM +0100, Alexander Aring wrote:
> Hi Steffen,
>
> On Fri, Dec 06, 2013 at 10:07:32AM +0100, Steffen Trumtrar wrote:
> > Hi!
> >
> > On Thu, Dec 05, 2013 at 12:28:11AM +0100, Alexander Aring wrote:
> > > The cadence serial driver is some ARCH_ZYNQ specific driver.
> > > Add a depends on ARCH_ZYNQ for this driver.
> > >
> > > Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> > > ---
> > > drivers/serial/Kconfig | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
> > > index 11fc155..d520dda 100644
> > > --- a/drivers/serial/Kconfig
> > > +++ b/drivers/serial/Kconfig
> > > @@ -119,6 +119,7 @@ config DRIVER_SERIAL_OMAP4_USBBOOT
> > >
> > > config DRIVER_SERIAL_CADENCE
> > > bool "Cadence UART driver"
> > > + depends on ARCH_ZYNQ
> > > help
> > > Say Y here if you have a Cadence serial IP core.
> > >
> > > --
> > > 1.8.4.2
> > >
> > >
> > > _______________________________________________
> > > barebox mailing list
> > > barebox@lists.infradead.org
> > > http://lists.infradead.org/mailman/listinfo/barebox
> > >
> >
> > Does is not compile with other archs?
> > This is intended to be a generic driver; Zynq just happens to be the only user.
> > -> It should not depend on ARCH_ZYNQ.
>
> oh, I first figure out a depends on COMMON_CLK was missing and though
> that this driver is a platform specific driver.
>
> When it's a generic driver we should add a "depends on COMMON_CLK"
or for this case a "select COMMON_CLK" would be better. :-)
- Alex
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] serial: add missing depends on ARCH_ZYNQ
2013-12-06 9:07 ` Steffen Trumtrar
2013-12-06 11:59 ` Alexander Aring
@ 2013-12-09 7:24 ` Alexander Aring
1 sibling, 0 replies; 5+ messages in thread
From: Alexander Aring @ 2013-12-09 7:24 UTC (permalink / raw)
To: Steffen Trumtrar; +Cc: barebox
Hi Steffen,
now I figoure out that this is a bigger problem.
There are architecture which not use the COMMON_CLK framework and has it
own clock framework implementation (for me it was ARCH_AT91). Then the
build failed.
So now we could make a depends on !ARCH_AT91 in COMMON_CLK and a depends
on COMMON_CLK in DRIVER_SERIAL_CADENCE... but this is very ugly and
maybe the ARCH_AT91 get a COMMON_CLK framework...
Sorry for the noise.
- Alex
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-12-09 7:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-04 23:28 [PATCH] serial: add missing depends on ARCH_ZYNQ Alexander Aring
2013-12-06 9:07 ` Steffen Trumtrar
2013-12-06 11:59 ` Alexander Aring
2013-12-06 12:18 ` Alexander Aring
2013-12-09 7:24 ` Alexander Aring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox