* [PATCH 02/12] ARM: guf-cupid: Use __iomem specifier for memory pointer
2014-01-25 19:34 [PATCH 01/12] ARM: animeo_ip: Use __iomem specifier for memory pointer Alexander Shiyan
@ 2014-01-25 19:34 ` Alexander Shiyan
2014-01-25 19:34 ` [PATCH 03/12] ARM: tqma6x: " Alexander Shiyan
` (10 subsequent siblings)
11 siblings, 0 replies; 15+ messages in thread
From: Alexander Shiyan @ 2014-01-25 19:34 UTC (permalink / raw)
To: barebox
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
arch/arm/boards/guf-cupid/lowlevel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boards/guf-cupid/lowlevel.c b/arch/arm/boards/guf-cupid/lowlevel.c
index d5298c1..3264a26 100644
--- a/arch/arm/boards/guf-cupid/lowlevel.c
+++ b/arch/arm/boards/guf-cupid/lowlevel.c
@@ -45,7 +45,7 @@
static void __bare_init noinline setup_sdram(u32 memsize, u32 mode, u32 sdram_addr)
{
volatile int loop;
- void *r9 = (void *)MX35_CSD0_BASE_ADDR;
+ void __iomem *r9 = IOMEM(MX35_CSD0_BASE_ADDR);
u32 r11 = 0xda; /* dummy constant */
u32 r1, r0;
--
1.8.3.2
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 15+ messages in thread* [PATCH 03/12] ARM: tqma6x: Use __iomem specifier for memory pointer
2014-01-25 19:34 [PATCH 01/12] ARM: animeo_ip: Use __iomem specifier for memory pointer Alexander Shiyan
2014-01-25 19:34 ` [PATCH 02/12] ARM: guf-cupid: " Alexander Shiyan
@ 2014-01-25 19:34 ` Alexander Shiyan
2014-01-25 19:34 ` [PATCH 04/12] ARM: uncompress: Remove unused variable Alexander Shiyan
` (9 subsequent siblings)
11 siblings, 0 replies; 15+ messages in thread
From: Alexander Shiyan @ 2014-01-25 19:34 UTC (permalink / raw)
To: barebox
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
arch/arm/boards/tqma6x/board.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boards/tqma6x/board.c b/arch/arm/boards/tqma6x/board.c
index a870bf2..6ece7b5 100644
--- a/arch/arm/boards/tqma6x/board.c
+++ b/arch/arm/boards/tqma6x/board.c
@@ -106,8 +106,8 @@ extern char flash_header_tqma6q_end[];
static int tqma6x_env_init(void)
{
- void *flash_header_start;
- void *flash_header_end;
+ void __iomem *flash_header_start;
+ void __iomem *flash_header_end;
if (of_machine_is_compatible("tq,tqma6s")) {
flash_header_start = (void *)flash_header_tqma6dl_start;
--
1.8.3.2
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 15+ messages in thread* [PATCH 04/12] ARM: uncompress: Remove unused variable
2014-01-25 19:34 [PATCH 01/12] ARM: animeo_ip: Use __iomem specifier for memory pointer Alexander Shiyan
2014-01-25 19:34 ` [PATCH 02/12] ARM: guf-cupid: " Alexander Shiyan
2014-01-25 19:34 ` [PATCH 03/12] ARM: tqma6x: " Alexander Shiyan
@ 2014-01-25 19:34 ` Alexander Shiyan
2014-01-25 19:34 ` [PATCH 05/12] ARM: PBL: Use __iomem specifier for memory pointer Alexander Shiyan
` (8 subsequent siblings)
11 siblings, 0 replies; 15+ messages in thread
From: Alexander Shiyan @ 2014-01-25 19:34 UTC (permalink / raw)
To: barebox
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
arch/arm/cpu/uncompress.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/arm/cpu/uncompress.c b/arch/arm/cpu/uncompress.c
index 6d3302a..7397c7d 100644
--- a/arch/arm/cpu/uncompress.c
+++ b/arch/arm/cpu/uncompress.c
@@ -46,7 +46,6 @@ static int __attribute__((__used__))
static void __noreturn noinline uncompress_start_payload(uint32_t membase,
uint32_t memsize, uint32_t boarddata)
{
- uint32_t offset;
uint32_t pg_len;
void __noreturn (*barebox)(uint32_t, uint32_t, uint32_t);
uint32_t endmem = membase + memsize;
@@ -61,9 +60,6 @@ static void __noreturn noinline uncompress_start_payload(uint32_t membase,
if (IS_ENABLED(CONFIG_PBL_RELOCATABLE))
relocate_to_current_adr();
- /* Get offset between linked address and runtime address */
- offset = get_runtime_offset();
-
if (IS_ENABLED(CONFIG_RELOCATABLE))
barebox_base = arm_barebox_image_place(membase + memsize);
else
--
1.8.3.2
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 15+ messages in thread* [PATCH 05/12] ARM: PBL: Use __iomem specifier for memory pointer
2014-01-25 19:34 [PATCH 01/12] ARM: animeo_ip: Use __iomem specifier for memory pointer Alexander Shiyan
` (2 preceding siblings ...)
2014-01-25 19:34 ` [PATCH 04/12] ARM: uncompress: Remove unused variable Alexander Shiyan
@ 2014-01-25 19:34 ` Alexander Shiyan
2014-01-25 19:34 ` [PATCH 06/12] lib: bootz: " Alexander Shiyan
` (7 subsequent siblings)
11 siblings, 0 replies; 15+ messages in thread
From: Alexander Shiyan @ 2014-01-25 19:34 UTC (permalink / raw)
To: barebox
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
arch/arm/cpu/start-pbl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/cpu/start-pbl.c b/arch/arm/cpu/start-pbl.c
index 3ef0118..ef6bb9d 100644
--- a/arch/arm/cpu/start-pbl.c
+++ b/arch/arm/cpu/start-pbl.c
@@ -45,8 +45,8 @@ void __naked __section(.text_head_entry) pbl_start(void)
barebox_arm_head();
}
-extern void *input_data;
-extern void *input_data_end;
+extern void __iomem *input_data;
+extern void __iomem *input_data_end;
static noinline __noreturn void __barebox_arm_entry(uint32_t membase,
uint32_t memsize, uint32_t boarddata)
--
1.8.3.2
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 15+ messages in thread* [PATCH 06/12] lib: bootz: Use __iomem specifier for memory pointer
2014-01-25 19:34 [PATCH 01/12] ARM: animeo_ip: Use __iomem specifier for memory pointer Alexander Shiyan
` (3 preceding siblings ...)
2014-01-25 19:34 ` [PATCH 05/12] ARM: PBL: Use __iomem specifier for memory pointer Alexander Shiyan
@ 2014-01-25 19:34 ` Alexander Shiyan
2014-01-25 19:34 ` [PATCH 07/12] lib: bootm: " Alexander Shiyan
` (6 subsequent siblings)
11 siblings, 0 replies; 15+ messages in thread
From: Alexander Shiyan @ 2014-01-25 19:34 UTC (permalink / raw)
To: barebox
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
arch/arm/lib/bootz.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/lib/bootz.c b/arch/arm/lib/bootz.c
index e32a77b..791ca81 100644
--- a/arch/arm/lib/bootz.c
+++ b/arch/arm/lib/bootz.c
@@ -25,8 +25,8 @@ static int do_bootz(int argc, char *argv[])
{
int fd, ret, swap = 0;
struct zimage_header __header, *header;
- void *zimage;
- void *oftree = NULL;
+ void __iomem *zimage;
+ void __iomem *oftree = NULL;
u32 end;
int usemap = 0;
struct memory_bank *bank = list_first_entry(&memory_banks, struct memory_bank, list);
--
1.8.3.2
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 15+ messages in thread* [PATCH 07/12] lib: bootm: Use __iomem specifier for memory pointer
2014-01-25 19:34 [PATCH 01/12] ARM: animeo_ip: Use __iomem specifier for memory pointer Alexander Shiyan
` (4 preceding siblings ...)
2014-01-25 19:34 ` [PATCH 06/12] lib: bootz: " Alexander Shiyan
@ 2014-01-25 19:34 ` Alexander Shiyan
2014-01-25 19:34 ` [PATCH 08/12] ARM: at91: boot_test_cmd: " Alexander Shiyan
` (5 subsequent siblings)
11 siblings, 0 replies; 15+ messages in thread
From: Alexander Shiyan @ 2014-01-25 19:34 UTC (permalink / raw)
To: barebox
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
arch/arm/lib/bootm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/lib/bootm.c b/arch/arm/lib/bootm.c
index c0e4e15..87ee89d 100644
--- a/arch/arm/lib/bootm.c
+++ b/arch/arm/lib/bootm.c
@@ -142,7 +142,7 @@ struct zimage_header {
static int do_bootz_linux_fdt(int fd, struct image_data *data)
{
struct fdt_header __header, *header;
- void *oftree;
+ void __iomem *oftree;
int ret;
u32 end;
@@ -204,7 +204,7 @@ static int do_bootz_linux(struct image_data *data)
{
int fd, ret, swap = 0;
struct zimage_header __header, *header;
- void *zimage;
+ void __iomem *zimage;
u32 end;
unsigned long load_address = data->os_address;
--
1.8.3.2
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 15+ messages in thread* [PATCH 08/12] ARM: at91: boot_test_cmd: Use __iomem specifier for memory pointer
2014-01-25 19:34 [PATCH 01/12] ARM: animeo_ip: Use __iomem specifier for memory pointer Alexander Shiyan
` (5 preceding siblings ...)
2014-01-25 19:34 ` [PATCH 07/12] lib: bootm: " Alexander Shiyan
@ 2014-01-25 19:34 ` Alexander Shiyan
2014-01-29 17:50 ` Jean-Christophe PLAGNIOL-VILLARD
2014-01-25 19:34 ` [PATCH 09/12] ARM: at91: irq_fixup: " Alexander Shiyan
` (4 subsequent siblings)
11 siblings, 1 reply; 15+ messages in thread
From: Alexander Shiyan @ 2014-01-25 19:34 UTC (permalink / raw)
To: barebox
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
arch/arm/mach-at91/boot_test_cmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-at91/boot_test_cmd.c b/arch/arm/mach-at91/boot_test_cmd.c
index aa5c020..c0658b9 100644
--- a/arch/arm/mach-at91/boot_test_cmd.c
+++ b/arch/arm/mach-at91/boot_test_cmd.c
@@ -17,7 +17,7 @@ static int do_at91_boot_test(int argc, char *argv[])
{
int opt;
u32 *buf32;
- void *buf;
+ void __iomem *buf;
void (*jump)(void) = NULL;
int fd;
int ret = 1;
--
1.8.3.2
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 08/12] ARM: at91: boot_test_cmd: Use __iomem specifier for memory pointer
2014-01-25 19:34 ` [PATCH 08/12] ARM: at91: boot_test_cmd: " Alexander Shiyan
@ 2014-01-29 17:50 ` Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 0 replies; 15+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2014-01-29 17:50 UTC (permalink / raw)
To: Alexander Shiyan; +Cc: barebox
On 23:34 Sat 25 Jan , Alexander Shiyan wrote:
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> arch/arm/mach-at91/boot_test_cmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-at91/boot_test_cmd.c b/arch/arm/mach-at91/boot_test_cmd.c
> index aa5c020..c0658b9 100644
> --- a/arch/arm/mach-at91/boot_test_cmd.c
> +++ b/arch/arm/mach-at91/boot_test_cmd.c
> @@ -17,7 +17,7 @@ static int do_at91_boot_test(int argc, char *argv[])
> {
> int opt;
> u32 *buf32;
> - void *buf;
> + void __iomem *buf;
this is a RAM no __iomem
iomem is for register
Best Resgards,
J.
> void (*jump)(void) = NULL;
> int fd;
> int ret = 1;
> --
> 1.8.3.2
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 09/12] ARM: at91: irq_fixup: Use __iomem specifier for memory pointer
2014-01-25 19:34 [PATCH 01/12] ARM: animeo_ip: Use __iomem specifier for memory pointer Alexander Shiyan
` (6 preceding siblings ...)
2014-01-25 19:34 ` [PATCH 08/12] ARM: at91: boot_test_cmd: " Alexander Shiyan
@ 2014-01-25 19:34 ` Alexander Shiyan
2014-01-25 19:34 ` [PATCH 10/12] ARM: i.MX: external_nand_boot: " Alexander Shiyan
` (3 subsequent siblings)
11 siblings, 0 replies; 15+ messages in thread
From: Alexander Shiyan @ 2014-01-25 19:34 UTC (permalink / raw)
To: barebox
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
arch/arm/mach-at91/irq_fixup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-at91/irq_fixup.c b/arch/arm/mach-at91/irq_fixup.c
index a9eebd7..9815ac2 100644
--- a/arch/arm/mach-at91/irq_fixup.c
+++ b/arch/arm/mach-at91/irq_fixup.c
@@ -15,7 +15,7 @@
*/
void at91_rtt_irq_fixup(void *base)
{
- void *reg = base + AT91_RTT_MR;
+ void __iomem *reg = base + AT91_RTT_MR;
u32 mr = readl(reg);
writel(mr & ~(AT91_RTT_ALMIEN | AT91_RTT_RTTINCIEN), reg);
--
1.8.3.2
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 15+ messages in thread* [PATCH 10/12] ARM: i.MX: external_nand_boot: Use __iomem specifier for memory pointer
2014-01-25 19:34 [PATCH 01/12] ARM: animeo_ip: Use __iomem specifier for memory pointer Alexander Shiyan
` (7 preceding siblings ...)
2014-01-25 19:34 ` [PATCH 09/12] ARM: at91: irq_fixup: " Alexander Shiyan
@ 2014-01-25 19:34 ` Alexander Shiyan
2014-01-25 19:34 ` [PATCH 11/12] ARM: i.MX: esdctl: " Alexander Shiyan
` (2 subsequent siblings)
11 siblings, 0 replies; 15+ messages in thread
From: Alexander Shiyan @ 2014-01-25 19:34 UTC (permalink / raw)
To: barebox
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
arch/arm/mach-imx/external-nand-boot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-imx/external-nand-boot.c b/arch/arm/mach-imx/external-nand-boot.c
index 1af46b7..2dabd53 100644
--- a/arch/arm/mach-imx/external-nand-boot.c
+++ b/arch/arm/mach-imx/external-nand-boot.c
@@ -28,7 +28,7 @@
#include <mach/imx31-regs.h>
#include <mach/imx35-regs.h>
-static void __bare_init noinline imx_nandboot_wait_op_done(void *regs)
+static void __bare_init noinline imx_nandboot_wait_op_done(void __iomem *regs)
{
u32 r;
--
1.8.3.2
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 15+ messages in thread* [PATCH 11/12] ARM: i.MX: esdctl: Use __iomem specifier for memory pointer
2014-01-25 19:34 [PATCH 01/12] ARM: animeo_ip: Use __iomem specifier for memory pointer Alexander Shiyan
` (8 preceding siblings ...)
2014-01-25 19:34 ` [PATCH 10/12] ARM: i.MX: external_nand_boot: " Alexander Shiyan
@ 2014-01-25 19:34 ` Alexander Shiyan
2014-01-25 19:34 ` [PATCH 12/12] ARM: i.MX: esdctl-v4: " Alexander Shiyan
2014-01-29 9:23 ` [PATCH 01/12] ARM: animeo_ip: " Sascha Hauer
11 siblings, 0 replies; 15+ messages in thread
From: Alexander Shiyan @ 2014-01-25 19:34 UTC (permalink / raw)
To: barebox
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
arch/arm/mach-imx/esdctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-imx/esdctl.c b/arch/arm/mach-imx/esdctl.c
index 3ac4075..d11957f 100644
--- a/arch/arm/mach-imx/esdctl.c
+++ b/arch/arm/mach-imx/esdctl.c
@@ -195,7 +195,7 @@ static void add_mem(unsigned long base0, unsigned long size0,
*/
#define ESDCTL1_RESET_DEFAULT 0x81120080
-static inline void imx_esdctl_v2_disable_default(void *esdctlbase)
+static inline void imx_esdctl_v2_disable_default(void __iomem *esdctlbase)
{
u32 ctlval = readl(esdctlbase + IMX_ESDCTL1);
--
1.8.3.2
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 15+ messages in thread* [PATCH 12/12] ARM: i.MX: esdctl-v4: Use __iomem specifier for memory pointer
2014-01-25 19:34 [PATCH 01/12] ARM: animeo_ip: Use __iomem specifier for memory pointer Alexander Shiyan
` (9 preceding siblings ...)
2014-01-25 19:34 ` [PATCH 11/12] ARM: i.MX: esdctl: " Alexander Shiyan
@ 2014-01-25 19:34 ` Alexander Shiyan
2014-01-29 9:23 ` [PATCH 01/12] ARM: animeo_ip: " Sascha Hauer
11 siblings, 0 replies; 15+ messages in thread
From: Alexander Shiyan @ 2014-01-25 19:34 UTC (permalink / raw)
To: barebox
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
arch/arm/mach-imx/esdctl-v4.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/arch/arm/mach-imx/esdctl-v4.c b/arch/arm/mach-imx/esdctl-v4.c
index 6441ac9..0652b49 100644
--- a/arch/arm/mach-imx/esdctl-v4.c
+++ b/arch/arm/mach-imx/esdctl-v4.c
@@ -25,7 +25,7 @@
void imx_esdctlv4_do_write_leveling(void)
{
u32 val;
- void __iomem *base = (void *)MX53_ESDCTL_BASE_ADDR;
+ void __iomem *base = IOMEM(MX53_ESDCTL_BASE_ADDR);
/* switch RAMs to write-leveling mode */
@@ -80,7 +80,7 @@ void imx_esdctlv4_do_write_leveling(void)
void imx_esdctlv4_do_dqs_gating(void)
{
u32 val;
- void __iomem *base = (void *)MX53_ESDCTL_BASE_ADDR;
+ void __iomem *base = IOMEM(MX53_ESDCTL_BASE_ADDR);
/* configure ESDCTL comparator to use MPR pattern */
writel(ESDCTL_V4_PDCMPR2_MPR_FULL_CMP | ESDCTL_V4_PDCMPR2_MPR_CMP,
@@ -127,7 +127,7 @@ void imx_esdctlv4_do_dqs_gating(void)
void imx_esdctlv4_do_zq_calibration(void)
{
u32 val;
- void __iomem *base = (void *)MX53_ESDCTL_BASE_ADDR;
+ void __iomem *base = IOMEM(MX53_ESDCTL_BASE_ADDR);
/*
* configure ZQ parameters
@@ -156,7 +156,7 @@ void imx_esdctlv4_do_zq_calibration(void)
*/
void imx_esdctlv4_start_ddr3_sdram(int cs)
{
- void __iomem *base = (void *)MX53_ESDCTL_BASE_ADDR;
+ void __iomem *base = IOMEM(MX53_ESDCTL_BASE_ADDR);
u32 val;
u32 val_cs1;
@@ -206,7 +206,7 @@ void imx_esdctlv4_start_ddr3_sdram(int cs)
void imx_esdctlv4_do_read_delay_line_calibration(void)
{
- void __iomem *base = (void *)MX53_ESDCTL_BASE_ADDR;
+ void __iomem *base = IOMEM(MX53_ESDCTL_BASE_ADDR);
u32 val;
/* configure ESDCTL comparator to use MPR pattern */
@@ -262,7 +262,7 @@ void imx_esdctlv4_do_read_delay_line_calibration(void)
void imx_esdctlv4_do_write_delay_line_calibration(void)
{
- void __iomem *base = (void *)MX53_ESDCTL_BASE_ADDR;
+ void __iomem *base = IOMEM(MX53_ESDCTL_BASE_ADDR);
void __iomem *adr;
u32 val;
@@ -275,7 +275,7 @@ void imx_esdctlv4_do_write_delay_line_calibration(void)
/* write test-pattern to RAM */
/* ESCTL uses this address for calibration */
- adr = (void *)MX53_CSD0_BASE_ADDR + 0x10000000;
+ adr = IOMEM(MX53_CSD0_BASE_ADDR) + 0x10000000;
writel(0, adr + 0x00);
writel(0, adr + 0x0c);
writel(0, adr + 0x10);
@@ -328,7 +328,7 @@ void imx_esdctlv4_do_write_delay_line_calibration(void)
/*
* write magic values to RAM for testing purposes
*/
-static void imx_esdctlv4_write_magic_values(void *adr)
+static void imx_esdctlv4_write_magic_values(void __iomem *adr)
{
/*
* Freescale asks for first access to be a write to properly
@@ -348,7 +348,7 @@ static void imx_esdctlv4_write_magic_values(void *adr)
/*
* check if given DRAM addresses match expected values for row/col configuration
*/
-static u32 check_ram_address_line(void *adr, u32 compare, u32 mask)
+static u32 check_ram_address_line(void __iomem *adr, u32 compare, u32 mask)
{
u32 val;
@@ -366,7 +366,7 @@ static u32 check_ram_address_line(void *adr, u32 compare, u32 mask)
*/
void imx_esdctlv4_set_tRFC_timing(void)
{
- void __iomem *base = (void *)MX53_ESDCTL_BASE_ADDR;
+ void __iomem *base = IOMEM(MX53_ESDCTL_BASE_ADDR);
u32 val, trfc, r2, esdcfg;
/* determine chip-density */
@@ -433,7 +433,7 @@ void imx_esdctlv4_set_tRFC_timing(void)
*/
void imx_esdctlv4_detect_sdrams(void)
{
- void __iomem *base = (void *)MX53_ESDCTL_BASE_ADDR;
+ void __iomem *base = IOMEM(MX53_ESDCTL_BASE_ADDR);
u32 esdctl0;
esdctl0 = readl(base + ESDCTL_V4_ESDCTL0);
@@ -451,7 +451,7 @@ void imx_esdctlv4_detect_sdrams(void)
void imx_esdctlv4_init(void)
{
- void __iomem *base = (void *)MX53_ESDCTL_BASE_ADDR;
+ void __iomem *base = IOMEM(MX53_ESDCTL_BASE_ADDR);
u32 val, r1, esdctl0, mask, rows, cols;
/*
--
1.8.3.2
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 01/12] ARM: animeo_ip: Use __iomem specifier for memory pointer
2014-01-25 19:34 [PATCH 01/12] ARM: animeo_ip: Use __iomem specifier for memory pointer Alexander Shiyan
` (10 preceding siblings ...)
2014-01-25 19:34 ` [PATCH 12/12] ARM: i.MX: esdctl-v4: " Alexander Shiyan
@ 2014-01-29 9:23 ` Sascha Hauer
2014-01-29 17:51 ` Jean-Christophe PLAGNIOL-VILLARD
11 siblings, 1 reply; 15+ messages in thread
From: Sascha Hauer @ 2014-01-29 9:23 UTC (permalink / raw)
To: Alexander Shiyan; +Cc: barebox
Hi Alexander,
from this series I applied:
ARM: uncompress: Remove unused variable
cleanup
ARM: animeo_ip: Use __iomem specifier for memory pointer
ARM: at91: irq_fixup: Use __iomem specifier for memory pointer
ARM: i.MX: external_nand_boot: Use __iomem specifier for memory pointer
ARM: i.MX: esdctl: Use __iomem specifier for memory pointer
ARM: i.MX: esdctl-v4: Use __iomem specifier for memory pointer
These are cases in which registers are accessed and __iomem should be
used.
For the remaining I am unsure as it's RAM that's accessed there. I don't
think these should have __iomem.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PATCH 01/12] ARM: animeo_ip: Use __iomem specifier for memory pointer
2014-01-29 9:23 ` [PATCH 01/12] ARM: animeo_ip: " Sascha Hauer
@ 2014-01-29 17:51 ` Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 0 replies; 15+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2014-01-29 17:51 UTC (permalink / raw)
To: Sascha Hauer; +Cc: barebox
On 10:23 Wed 29 Jan , Sascha Hauer wrote:
> Hi Alexander,
>
> from this series I applied:
>
> ARM: uncompress: Remove unused variable
>
> cleanup
>
> ARM: animeo_ip: Use __iomem specifier for memory pointer
> ARM: at91: irq_fixup: Use __iomem specifier for memory pointer
> ARM: i.MX: external_nand_boot: Use __iomem specifier for memory pointer
> ARM: i.MX: esdctl: Use __iomem specifier for memory pointer
> ARM: i.MX: esdctl-v4: Use __iomem specifier for memory pointer
>
> These are cases in which registers are accessed and __iomem should be
> used.
>
> For the remaining I am unsure as it's RAM that's accessed there. I don't
> think these should have __iomem.
__iomem is for register access not ram access
Best Regards,
J.
>
> Sascha
>
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 15+ messages in thread