mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Alexander Shiyan <shc_work@mail.ru>
To: barebox@lists.infradead.org
Subject: [PATCH 2/4] ppc 8xxx: Fix logic
Date: Wed, 29 Jan 2014 22:21:47 +0400	[thread overview]
Message-ID: <1391019709-30606-2-git-send-email-shc_work@mail.ru> (raw)
In-Reply-To: <1391019709-30606-1-git-send-email-shc_work@mail.ru>

Expression (pdimm->data_width >= 32) || (pdimm->data_width <= 40)
always evaluates to true, so probably we need to use "&&" here.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 arch/ppc/ddr-8xxx/options.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/ppc/ddr-8xxx/options.c b/arch/ppc/ddr-8xxx/options.c
index 22b621f..9ce2bc1 100644
--- a/arch/ppc/ddr-8xxx/options.c
+++ b/arch/ppc/ddr-8xxx/options.c
@@ -48,7 +48,7 @@ uint32_t populate_memctl_options(int all_DIMMs_registered,
 	if (pdimm->n_ranks != 0) {
 		if ((pdimm->data_width >= 64) && (pdimm->data_width <= 72))
 			popts->data_bus_width = 0;
-		else if ((pdimm->data_width >= 32) ||
+		else if ((pdimm->data_width >= 32) &&
 			(pdimm->data_width <= 40))
 			popts->data_bus_width = 1;
 		else
-- 
1.8.3.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2014-01-29 18:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-29 18:21 [PATCH 1/4] MIPS: mach-ar231x: Fix uninitialized variable Alexander Shiyan
2014-01-29 18:21 ` Alexander Shiyan [this message]
2014-01-29 18:21 ` [PATCH 3/4] gadget: at91: " Alexander Shiyan
2014-01-29 18:21 ` [PATCH 4/4] scripts: imx-usb-loader: Fix memory leak Alexander Shiyan
2014-01-29 20:39 ` [PATCH 1/4] MIPS: mach-ar231x: Fix uninitialized variable Sascha Hauer
2014-01-30  6:39   ` Alexander Shiyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1391019709-30606-2-git-send-email-shc_work@mail.ru \
    --to=shc_work@mail.ru \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox