mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Lucas Stach <dev@lynxeye.de>
To: barebox@lists.infradead.org
Subject: [PATCH 06/14] lib: libbb: f should never be NULL
Date: Fri,  7 Feb 2014 09:48:48 +0100	[thread overview]
Message-ID: <1391762936-2747-7-git-send-email-dev@lynxeye.de> (raw)
In-Reply-To: <1391762936-2747-1-git-send-email-dev@lynxeye.de>

We assume it to be non NULL in other places, so
we are in much greater trouble if it actually is.

Signed-off-by: Lucas Stach <dev@lynxeye.de>
---
 lib/libbb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/libbb.c b/lib/libbb.c
index 189a170..dd42e66 100644
--- a/lib/libbb.c
+++ b/lib/libbb.c
@@ -43,7 +43,7 @@ EXPORT_SYMBOL(concat_path_file);
 
 char *concat_subpath_file(const char *path, const char *f)
 {
-	if (f && DOT_OR_DOTDOT(f))
+	if (DOT_OR_DOTDOT(f))
 		return NULL;
 	return concat_path_file(path, f);
 }
-- 
1.8.5.3


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2014-02-07  8:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-07  8:48 [PATCH 00/14] Smatch warning fixups Lucas Stach
2014-02-07  8:48 ` [PATCH 01/14] remove redundant NULL check on free Lucas Stach
2014-02-07  8:48 ` [PATCH 02/14] commands: edit: properly propagate error code Lucas Stach
2014-02-07  8:48 ` [PATCH 03/14] common: env: " Lucas Stach
2014-02-07  8:48 ` [PATCH 04/14] clk: imx: unsigned mfn is never less than zero Lucas Stach
2014-02-07  8:48 ` [PATCH 05/14] lib: math: fix return path (numstack may be NULL) Lucas Stach
2014-02-07  8:48 ` Lucas Stach [this message]
2014-02-07  8:48 ` [PATCH 07/14] comamnds: uimage: actually print error message Lucas Stach
2014-02-07  9:22   ` Uwe Kleine-König
2014-02-07  8:48 ` [PATCH 08/14] usb: ulpi: fix logic-op Lucas Stach
2014-02-07  8:48 ` [PATCH 09/14] usb: dfu: fix error path to avoid NULL ptr deref Lucas Stach
2014-02-07  8:48 ` [PATCH 10/14] net: usb: smsc95xx: fix wrong phy reset condition Lucas Stach
2014-02-07  8:48 ` [PATCH 11/14] net: usb: asix: properly propagate error code Lucas Stach
2014-02-07  8:48 ` [PATCH 12/14] mtd: core: avoid possible NULL ptr deref Lucas Stach
2014-02-07  8:48 ` [PATCH 13/14] clk: " Lucas Stach
2014-02-07  8:48 ` [PATCH 14/14] don't cast negative error codes to unsigned size_t Lucas Stach
2014-02-07  9:17   ` Juergen Beisert
2014-02-10  7:51 ` [PATCH 00/14] Smatch warning fixups Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1391762936-2747-7-git-send-email-dev@lynxeye.de \
    --to=dev@lynxeye.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox