From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH 4/4] USB gadget: dfu: propagate error from usb_gadget_poll
Date: Thu, 13 Feb 2014 10:42:53 +0100 [thread overview]
Message-ID: <1392284573-22410-5-git-send-email-s.hauer@pengutronix.de> (raw)
In-Reply-To: <1392284573-22410-1-git-send-email-s.hauer@pengutronix.de>
So that the dfu command can bail out with an error when usb_gadget_poll
fails.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/usb/gadget/dfu.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/dfu.c b/drivers/usb/gadget/dfu.c
index e15fc41..5d6d400 100644
--- a/drivers/usb/gadget/dfu.c
+++ b/drivers/usb/gadget/dfu.c
@@ -682,6 +682,8 @@ static struct usb_composite_driver dfu_driver = {
int usb_dfu_register(struct usb_dfu_pdata *pdata)
{
+ int ret;
+
dfu_devs = pdata->alts;
dfu_num_alt = pdata->num_alts;
dfu_dev_descriptor.idVendor = pdata->idVendor;
@@ -692,7 +694,10 @@ int usb_dfu_register(struct usb_dfu_pdata *pdata)
usb_composite_register(&dfu_driver);
while (1) {
- usb_gadget_poll();
+ ret = usb_gadget_poll();
+ if (ret < 0)
+ return ret;
+
if (ctrlc() || dfudetach)
goto out;
}
--
1.8.5.3
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2014-02-13 9:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 9:42 USB gadget / dfu fixes Sascha Hauer
2014-02-13 9:42 ` [PATCH 1/4] USB gadget: at91: return error when no udc is registered Sascha Hauer
2014-02-13 9:42 ` [PATCH 2/4] dfu command: check return values Sascha Hauer
2014-02-13 9:42 ` [PATCH 3/4] USB gadget: fsl: Bail out if no udc exists Sascha Hauer
2014-02-13 9:42 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392284573-22410-5-git-send-email-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox