From: "Alexander Shiyan" <shc_work@mail.ru>
To: "Sascha Hauer" <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/8] common/kallsyms.c: Fix sparse warning
Date: Mon, 17 Feb 2014 11:30:58 +0400 [thread overview]
Message-ID: <1392622258.412211244@f35.i.mail.ru> (raw)
In-Reply-To: <20140217072508.GL17250@pengutronix.de>
Понедельник, 17 февраля 2014, 8:25 +01:00 от Sascha Hauer <s.hauer@pengutronix.de>:
> On Sun, Feb 16, 2014 at 11:24:30AM +0400, Alexander Shiyan wrote:
> > CHECK common/kallsyms.c
> > common/kallsyms.c:170:12: warning: symbol 'kallsyms_lookup' was not
> declared. Should it be static?
> >
> > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
>
> Applied all, although with some of them I'm not sure whether the correct
> fix would be to actually add the declaration to a header file instead of
> making the symbol static.
You are right, but declaration may be added as they are needed.
---
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2014-02-17 7:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-16 7:24 Alexander Shiyan
2014-02-16 7:24 ` [PATCH 2/8] drivers/clk/clk-fixed.c: " Alexander Shiyan
2014-02-16 7:24 ` [PATCH 3/8] drivers/clk/clk-fixed-factor.c: " Alexander Shiyan
2014-02-16 7:24 ` [PATCH 4/8] drivers/clk/clk-mux.c: " Alexander Shiyan
2014-02-16 7:24 ` [PATCH 5/8] drivers/clk/clk-gate.c: " Alexander Shiyan
2014-02-16 7:24 ` [PATCH 6/8] drivers/clk/clk-divider-table.c: " Alexander Shiyan
2014-02-16 7:24 ` [PATCH 7/8] drivers/i2c/i2c.c: Fix sparse warnings Alexander Shiyan
2014-02-16 7:24 ` [PATCH 8/8] drivers/of/base.c: " Alexander Shiyan
2014-02-17 7:25 ` [PATCH 1/8] common/kallsyms.c: Fix sparse warning Sascha Hauer
2014-02-17 7:30 ` Alexander Shiyan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392622258.412211244@f35.i.mail.ru \
--to=shc_work@mail.ru \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox