From: Alexander Shiyan <shc_work@mail.ru>
To: barebox@lists.infradead.org
Subject: [PATCH 02/12] gui: Fix resource leak
Date: Sat, 12 Apr 2014 12:10:55 +0400 [thread overview]
Message-ID: <1397290265-21273-2-git-send-email-shc_work@mail.ru> (raw)
In-Reply-To: <1397290265-21273-1-git-send-email-shc_work@mail.ru>
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
lib/gui/picopng.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/lib/gui/picopng.c b/lib/gui/picopng.c
index 77cd81c..e740b1c 100644
--- a/lib/gui/picopng.c
+++ b/lib/gui/picopng.c
@@ -761,9 +761,12 @@ int main(int argc, char **argv)
infp = fopen(fname, "rb");
if (!infp) {
perror("fopen");
+ free(inbuf);
return 1;
} else if (fread(inbuf, 1, insize, infp) != insize) {
perror("fread");
+ free(inbuf);
+ fclose(infp);
return 1;
}
fclose(infp);
@@ -793,6 +796,7 @@ int main(int argc, char **argv)
return 1;
} else if (fwrite(info->image->data, 1, outsize, outfp) != outsize) {
perror("fwrite");
+ fclose(outfp);
return 1;
}
fclose(outfp);
--
1.8.3.2
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-04-12 8:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-12 8:10 [PATCH 01/12] scripts: imx-image: " Alexander Shiyan
2014-04-12 8:10 ` Alexander Shiyan [this message]
2014-04-12 8:10 ` [PATCH 03/12] lzo: Remove unused variable Alexander Shiyan
2014-04-12 8:10 ` [PATCH 04/12] ubifs: " Alexander Shiyan
2014-04-12 8:10 ` [PATCH 05/12] commands/mount: Return real error code if "mount" fail Alexander Shiyan
2014-04-23 9:47 ` Sascha Hauer
2014-04-12 8:10 ` [PATCH 06/12] commands/uimage: Fix error printing Alexander Shiyan
2014-04-12 8:11 ` [PATCH 07/12] commands/umount: Return real error code if "umount" fail Alexander Shiyan
2014-04-23 9:54 ` Sascha Hauer
2014-04-12 8:11 ` [PATCH 08/12] commands/usbserial: Remove unused variable Alexander Shiyan
2014-04-12 8:11 ` [PATCH 09/12] ata: pata-imx: " Alexander Shiyan
2014-04-12 8:11 ` [PATCH 10/12] imx_keypad: Fix error handling Alexander Shiyan
2014-04-23 9:54 ` Sascha Hauer
2014-04-12 8:11 ` [PATCH 11/12] mtd: partition: Remove unused variable Alexander Shiyan
2014-04-12 8:11 ` [PATCH 12/12] mtd: nand: bbt: " Alexander Shiyan
2014-04-23 9:56 ` [PATCH 01/12] scripts: imx-image: Fix resource leak Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397290265-21273-2-git-send-email-shc_work@mail.ru \
--to=shc_work@mail.ru \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox