From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH 1/3] mii-tool: Fix string length
Date: Wed, 21 May 2014 14:09:54 +0200 [thread overview]
Message-ID: <1400674196-31951-2-git-send-email-s.hauer@pengutronix.de> (raw)
In-Reply-To: <1400674196-31951-1-git-send-email-s.hauer@pengutronix.de>
media_list writes into a static string. Worst case length of this string
is 125 bytes, but the function only allocates 100 bytes. Use 256 bytes which
is long enough for some extensions.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
commands/miitool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/commands/miitool.c b/commands/miitool.c
index 1e5d4eb..81b5a25 100644
--- a/commands/miitool.c
+++ b/commands/miitool.c
@@ -61,7 +61,7 @@ const struct {
static const char *media_list(unsigned mask, unsigned mask2, int best)
{
- static char buf[100];
+ static char buf[256];
int i;
*buf = '\0';
--
2.0.0.rc0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-05-21 12:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 12:09 [PATCH] mii-tool fixes Sascha Hauer
2014-05-21 12:09 ` Sascha Hauer [this message]
2014-05-21 12:09 ` [PATCH 2/3] mii-tool: Fix gigabit link test Sascha Hauer
2014-05-21 12:09 ` [PATCH 3/3] mii-tool: Fix gigabit advertise / link partner ability mixup Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400674196-31951-2-git-send-email-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox