From: Lucas Stach <l.stach@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: Kristof Roelants <kristof.roelants@tass.be>,
barebox@lists.infradead.org,
Sam Van Den Berge <sam.van.den.berge@tass.be>,
Daniele Lacamera <daniele.lacamera@tass.be>,
Daniele Lacamera <mlists@danielinux.net>
Subject: Re: [RFC] [WIP] incorporate picotcp into barebox: a small demo
Date: Mon, 26 May 2014 11:45:57 +0200 [thread overview]
Message-ID: <1401097557.4829.20.camel@weser.hi.pengutronix.de> (raw)
In-Reply-To: <20140525135819.ebfd62810f698e8f13dbf558@gmail.com>
Am Sonntag, den 25.05.2014, 13:58 +0400 schrieb Antony Pavlov:
> Hi all!
>
> I have adapted barebox for work with picotcp network stack.
>
> Picotcp is not a small piece of code so I can't easyly send
> a patch to the barebox maillist. I have put results of my work on github,
> see mini-howto below.
>
> This picotcp integration is a dirty hack in many ways.
> We need additional effors for adapting barebox and picotcp
> for more easy joint operation.
>
> Please express your opinion on my work. I'm awaiting your comments.
>
You forgot to mention one important thing: Why is this change beneficial
to barebox?
Please don't get me wrong this is in no way a criticism on your work. I
only skimmed through the branch as of now and can't really comment on
the change. So please help me out: do you feel the code is
leaner/cleaner than the existing barebox network support? Or what's your
motivation for this?
Regards,
Lucas
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-05-26 9:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-25 9:58 Antony Pavlov
2014-05-26 9:35 ` Daniele Lacamera
2014-05-26 9:45 ` Lucas Stach [this message]
2014-05-26 12:09 ` Antony Pavlov
2014-05-27 5:30 ` Sascha Hauer
2014-05-27 7:52 ` Daniele Lacamera
2014-05-27 9:46 ` Daniele Lacamera
2014-05-27 14:04 ` Antony Pavlov
2014-05-27 17:26 ` Daniele Lacamera
2014-05-29 5:40 ` Antony Pavlov
2014-05-28 6:08 ` Sascha Hauer
2014-05-28 7:23 ` Juergen Borleis
2014-05-28 10:32 ` Antony Pavlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401097557.4829.20.camel@weser.hi.pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=daniele.lacamera@tass.be \
--cc=kristof.roelants@tass.be \
--cc=mlists@danielinux.net \
--cc=sam.van.den.berge@tass.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox