From: Lucas Stach <l.stach@pengutronix.de>
To: Holger Schurig <holgerschurig@gmail.com>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: [PATCH 3/3] sandbox: work around missing of_add_memory_bank()
Date: Tue, 22 Jul 2014 10:50:42 +0200 [thread overview]
Message-ID: <1406019042.4667.23.camel@weser.hi.pengutronix.de> (raw)
In-Reply-To: <CAOpc7mGUTXhr6FaYvC54HgyvyT=UD=h8CrrwynKzVuSSiFE1pw@mail.gmail.com>
Am Dienstag, den 22.07.2014, 10:39 +0200 schrieb Holger Schurig:
> There are no memory banks in the sandbox, so adding a working
> of_add_memory_bank? How should that work? Or do you mean adding a
> dummy of_add_memory_bank() to arch/sandbox/os/board.c?
>
Can you please elaborate why of_add_memory() doesn't work if no memory
banks are there? Why do you need this ifdef in the first place? Your
commit message fails to explain this.
> > his adds ifdeffery (which everyone hates) just for the sake of a static checker
>
> You probably never have run "scan-build make" after "apt-get install
> clang-3.5" ?!?! For me, this two lines are minimal, and the amount
> of warnings that scan-build finds in barebox is staggering.
This argument doesn't work. The more interesting point here would be to
know how much of those are real problems. Different static checkers
expose vastly different signal-to-noise ratios.
I have run barebox through different static checkers, but as a fact I
default to only use those which don't require a build to be run and have
a high signal-to-noise ratio. Which doesn't mean clangs scan-build
couldn't be a welcome addition, so please convince me.
Regards,
Lucas
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-07-22 8:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 7:57 Holger Schurig
2014-07-22 8:32 ` Lucas Stach
2014-07-22 8:39 ` Holger Schurig
2014-07-22 8:50 ` Lucas Stach [this message]
2014-07-22 8:59 ` Holger Schurig
2014-07-22 9:09 ` Holger Schurig
2014-07-22 9:43 ` Lucas Stach
2014-07-22 10:25 ` Holger Schurig
2014-07-22 10:52 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406019042.4667.23.camel@weser.hi.pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=holgerschurig@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox