From: Lucas Stach <l.stach@pengutronix.de>
To: Holger Schurig <holgerschurig@gmail.com>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: [PATCH 3/3] sandbox: work around missing of_add_memory_bank()
Date: Tue, 22 Jul 2014 11:43:17 +0200 [thread overview]
Message-ID: <1406022197.4667.39.camel@weser.hi.pengutronix.de> (raw)
In-Reply-To: <CAOpc7mF2QKiSmi2LYpumpBOPyfwg5mkKkHTi2PK2Z4Ehv46GzA@mail.gmail.com>
Am Dienstag, den 22.07.2014, 11:09 +0200 schrieb Holger Schurig:
> Okay, another post, with less heat.
>
Yes, please let us keep the heat out of this argument.
> I asked you specifically if a proposed solution would be ok. You
> didn't answer at all. That proposed solution would still not "work"
> (it won't add a memory bank, because AFAIK in sandbox there are no
> memory banks at all, it just uses the hosts memory). It might compile,
> however and it might be a bit of unneeded code in the "make
> ARCH=sandbox sandbox_defconfig && make all" case.
>
I wasn't able to give any specific advice as I admitted I did not
understand the problem yet. I'm aware that there are no memory banks in
sandbox, but this doesn't explain a build failure. Your commit message
unfortunately didn't explain this either, that's why I asked you to
elaborate.
Now I actually looked up the code and I think an easier solution would
be to allow CONFIG_OFTREE_MEM_GENERIC to be enabled on sandbox. Would
this work for you?
> The tone of your mail made me think that I actually cannot convince
> you, that you don't want this. Your reference to signal-to-noise made
> me think this. I got the impression that you're dismissing the concept
> of static checking and of code-massaging to make that easier.
>
Sorry, if it seemed like I wanted to trash your contribution. This
wasn't my intention at all. I'm absolutely in favor of static checking
but found that clangs scan-build gives at lot of false positives on
other projects and I'm not really keen on adding ifdefs just for this
use-case. But as I said above there may be another solution.
Regards,
Lucas
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-07-22 9:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 7:57 Holger Schurig
2014-07-22 8:32 ` Lucas Stach
2014-07-22 8:39 ` Holger Schurig
2014-07-22 8:50 ` Lucas Stach
2014-07-22 8:59 ` Holger Schurig
2014-07-22 9:09 ` Holger Schurig
2014-07-22 9:43 ` Lucas Stach [this message]
2014-07-22 10:25 ` Holger Schurig
2014-07-22 10:52 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406022197.4667.39.camel@weser.hi.pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=holgerschurig@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox