mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] Makefile: enable Werror=implicit-function-declaration
@ 2014-09-15 21:51 Lucas Stach
  2014-09-16  6:08 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Lucas Stach @ 2014-09-15 21:51 UTC (permalink / raw)
  To: barebox

This should prevent us from ever again missing an
failure similar to that one fixed in ee3254569dab
(EFI: add missing include) by throwing a build error.

Signed-off-by: Lucas Stach <dev@lynxeye.de>
---
 Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Makefile b/Makefile
index b059c3a00eaa..90b2b6368554 100644
--- a/Makefile
+++ b/Makefile
@@ -300,6 +300,7 @@ LINUXINCLUDE    := -Iinclude -I$(srctree)/dts/include \
 CPPFLAGS        := -D__KERNEL__ -D__BAREBOX__ $(LINUXINCLUDE) -fno-builtin -ffreestanding
 
 CFLAGS          := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
+                   -Werror=implicit-function-declaration \
                    -fno-strict-aliasing -fno-common -Os -pipe
 AFLAGS          := -D__ASSEMBLY__
 
-- 
1.9.3


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Makefile: enable Werror=implicit-function-declaration
  2014-09-15 21:51 [PATCH] Makefile: enable Werror=implicit-function-declaration Lucas Stach
@ 2014-09-16  6:08 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2014-09-16  6:08 UTC (permalink / raw)
  To: Lucas Stach; +Cc: barebox

On Mon, Sep 15, 2014 at 11:51:35PM +0200, Lucas Stach wrote:
> This should prevent us from ever again missing an
> failure similar to that one fixed in ee3254569dab
> (EFI: add missing include) by throwing a build error.
> 
> Signed-off-by: Lucas Stach <dev@lynxeye.de>

Nice. I wonder why I never did that earlier. Applied, thanks

Sascha

> ---
>  Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Makefile b/Makefile
> index b059c3a00eaa..90b2b6368554 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -300,6 +300,7 @@ LINUXINCLUDE    := -Iinclude -I$(srctree)/dts/include \
>  CPPFLAGS        := -D__KERNEL__ -D__BAREBOX__ $(LINUXINCLUDE) -fno-builtin -ffreestanding
>  
>  CFLAGS          := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
> +                   -Werror=implicit-function-declaration \
>                     -fno-strict-aliasing -fno-common -Os -pipe
>  AFLAGS          := -D__ASSEMBLY__
>  
> -- 
> 1.9.3
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-09-16  6:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-15 21:51 [PATCH] Makefile: enable Werror=implicit-function-declaration Lucas Stach
2014-09-16  6:08 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox