From: Lucas Stach <dev@lynxeye.de>
To: barebox@lists.infradead.org
Subject: [PATCH 2/7] dfu: fix possible usage of uninitialized var
Date: Mon, 20 Oct 2014 20:15:56 +0200 [thread overview]
Message-ID: <1413828961-12605-2-git-send-email-dev@lynxeye.de> (raw)
In-Reply-To: <1413828961-12605-1-git-send-email-dev@lynxeye.de>
The error path would in fact use the status
variable without it being initialized first.
Signed-off-by: Lucas Stach <dev@lynxeye.de>
---
drivers/usb/gadget/dfu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/gadget/dfu.c b/drivers/usb/gadget/dfu.c
index 67a0703..351b584 100644
--- a/drivers/usb/gadget/dfu.c
+++ b/drivers/usb/gadget/dfu.c
@@ -207,6 +207,7 @@ dfu_bind(struct usb_configuration *c, struct usb_function *f)
dfu->dnreq = usb_ep_alloc_request(c->cdev->gadget->ep0);
if (!dfu->dnreq) {
printf("usb_ep_alloc_request failed\n");
+ status = -ENOMEM;
goto out;
}
dfu->dnreq->buf = dma_alloc(CONFIG_USBD_DFU_XFER_SIZE);
--
1.9.3
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-10-20 18:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 18:15 [PATCH 1/7] imx: ipu-v3: fix typo leading to build warning Lucas Stach
2014-10-20 18:15 ` Lucas Stach [this message]
2014-10-20 18:15 ` [PATCH 3/7] arm: boards: variscite-mx6: check i2c return value Lucas Stach
2014-10-20 18:15 ` [PATCH 4/7] arm: at91: remove unused variable Lucas Stach
2014-10-21 1:56 ` Bo Shen
2014-10-20 18:15 ` [PATCH 5/7] sha2: fix invalid length check Lucas Stach
2014-10-20 21:06 ` Alexander Aring
2014-10-21 11:09 ` Sascha Hauer
2014-10-20 18:16 ` [PATCH 6/7] i2c: at91: " Lucas Stach
2014-10-21 2:01 ` Bo Shen
2014-10-20 18:16 ` [PATCH 7/7] clk: gate: remove superfluous code Lucas Stach
2014-10-21 11:09 ` [PATCH 1/7] imx: ipu-v3: fix typo leading to build warning Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413828961-12605-2-git-send-email-dev@lynxeye.de \
--to=dev@lynxeye.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox