From: Lucas Stach <dev@lynxeye.de>
To: barebox@lists.infradead.org
Subject: [PATCH 11/12] tegra: remove custom UART setup
Date: Mon, 3 Nov 2014 23:52:23 +0100 [thread overview]
Message-ID: <1415055144-6119-11-git-send-email-dev@lynxeye.de> (raw)
In-Reply-To: <1415055144-6119-1-git-send-email-dev@lynxeye.de>
The config option doesn't make any sense anymore
when building a multiimage barebox. With a proper
DT built into the image we don't need the ODMdata
mechanism to find the debug UART anymore.
Signed-off-by: Lucas Stach <dev@lynxeye.de>
---
arch/arm/mach-tegra/Kconfig | 33 ---------------------
arch/arm/mach-tegra/include/mach/lowlevel.h | 45 -----------------------------
arch/arm/mach-tegra/tegra20.c | 41 --------------------------
3 files changed, 119 deletions(-)
diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig
index 1bdea8e..160732f 100644
--- a/arch/arm/mach-tegra/Kconfig
+++ b/arch/arm/mach-tegra/Kconfig
@@ -7,39 +7,6 @@ config ARCH_TEXT_BASE
config BOARDINFO
default ""
-choice
- prompt "Tegra debug UART"
- help
- This is the first serial console that gets activated by barebox.
- Normally each board vendor should program a valid debug UART into
- the ODMdata section of the boot configuration table, so it's a
- reasonably good bet to use that.
- If you know your ODMdata is broken, or you don't wish to activate
- any serial console at all you can override the default here.
-
-config TEGRA_UART_ODMDATA
- bool "ODMdata defined UART"
-
-config TEGRA_UART_A
- bool "UART A"
-
-config TEGRA_UART_B
- bool "UART B"
-
-config TEGRA_UART_C
- bool "UART C"
-
-config TEGRA_UART_D
- bool "UART D"
-
-config TEGRA_UART_E
- bool "UART E"
-
-config TEGRA_UART_NONE
- bool "None"
-
-endchoice
-
# ---------------------------------------------------------
config ARCH_TEGRA_2x_SOC
diff --git a/arch/arm/mach-tegra/include/mach/lowlevel.h b/arch/arm/mach-tegra/include/mach/lowlevel.h
index c65be0b..3e7e41b 100644
--- a/arch/arm/mach-tegra/include/mach/lowlevel.h
+++ b/arch/arm/mach-tegra/include/mach/lowlevel.h
@@ -176,37 +176,6 @@ uint32_t tegra30_get_ramsize(void)
}
}
-static long uart_id_to_base[] = {
- TEGRA_UARTA_BASE,
- TEGRA_UARTB_BASE,
- TEGRA_UARTC_BASE,
- TEGRA_UARTD_BASE,
- TEGRA_UARTE_BASE,
-};
-
-static __always_inline
-long tegra20_get_debuguart_base(void)
-{
- u32 odmdata;
- int id;
-
- odmdata = tegra_get_odmdata();
-
- /*
- * Get type, we accept both "2" and "3", as they both demark a UART,
- * depending on the board type.
- */
- if (!(((odmdata & T20_ODMDATA_UARTTYPE_MASK) >>
- T20_ODMDATA_UARTTYPE_SHIFT) & 0x2))
- return 0;
-
- id = (odmdata & T20_ODMDATA_UARTID_MASK) >> T20_ODMDATA_UARTID_SHIFT;
- if (id > ARRAY_SIZE(uart_id_to_base))
- return 0;
-
- return uart_id_to_base[id];
-}
-
#define CRC_OSC_CTRL 0x050
#define CRC_OSC_CTRL_OSC_FREQ_SHIFT 30
#define CRC_OSC_CTRL_OSC_FREQ_MASK (0x3 << CRC_OSC_CTRL_OSC_FREQ_SHIFT)
@@ -231,20 +200,6 @@ int tegra_get_osc_clock(void)
}
}
-static __always_inline
-int tegra_get_pllp_rate(void)
-{
- switch (tegra_get_chiptype()) {
- case TEGRA20:
- return 216000000;
- case TEGRA30:
- case TEGRA124:
- return 408000000;
- default:
- return 0;
- }
-}
-
#define TIMER_CNTR_1US 0x00
#define TIMER_USEC_CFG 0x04
diff --git a/arch/arm/mach-tegra/tegra20.c b/arch/arm/mach-tegra/tegra20.c
index dcc55ae..8d1cd5b 100644
--- a/arch/arm/mach-tegra/tegra20.c
+++ b/arch/arm/mach-tegra/tegra20.c
@@ -22,47 +22,6 @@
#include <mach/lowlevel.h>
#include <mach/tegra114-sysctr.h>
-static struct NS16550_plat debug_uart = {
- .shift = 2,
-};
-
-static int tegra_add_debug_console(void)
-{
- unsigned long base = 0;
-
- if (!of_machine_is_compatible("nvidia,tegra20") &&
- !of_machine_is_compatible("nvidia,tegra30") &&
- !of_machine_is_compatible("nvidia,tegra124"))
- return 0;
-
- /* figure out which UART to use */
- if (IS_ENABLED(CONFIG_TEGRA_UART_NONE))
- return 0;
- if (IS_ENABLED(CONFIG_TEGRA_UART_ODMDATA))
- base = tegra20_get_debuguart_base();
- if (IS_ENABLED(CONFIG_TEGRA_UART_A))
- base = TEGRA_UARTA_BASE;
- if (IS_ENABLED(CONFIG_TEGRA_UART_B))
- base = TEGRA_UARTB_BASE;
- if (IS_ENABLED(CONFIG_TEGRA_UART_C))
- base = TEGRA_UARTC_BASE;
- if (IS_ENABLED(CONFIG_TEGRA_UART_D))
- base = TEGRA_UARTD_BASE;
- if (IS_ENABLED(CONFIG_TEGRA_UART_E))
- base = TEGRA_UARTE_BASE;
-
- if (!base)
- return -ENODEV;
-
- debug_uart.clock = tegra_get_pllp_rate();
-
- add_ns16550_device(DEVICE_ID_DYNAMIC, base, 8 << debug_uart.shift,
- IORESOURCE_MEM | IORESOURCE_MEM_8BIT, &debug_uart);
-
- return 0;
-}
-console_initcall(tegra_add_debug_console);
-
static int tegra20_mem_init(void)
{
if (!of_machine_is_compatible("nvidia,tegra20"))
--
1.9.3
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-11-03 22:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 22:52 [PATCH 01/12] tegra: beaver: set hostname in board init Lucas Stach
2014-11-03 22:52 ` [PATCH 02/12] tegra: jetson-tk1: " Lucas Stach
2014-11-03 22:52 ` [PATCH 03/12] tegra: colibri-t20: " Lucas Stach
2014-11-03 22:52 ` [PATCH 04/12] tegra: beaver: switch to upstream Tegra30 dtsi Lucas Stach
2014-11-03 22:52 ` [PATCH 05/12] tegra: beaver: add stdout-path Lucas Stach
2014-11-03 22:52 ` [PATCH 06/12] tegra: colibri-t20: " Lucas Stach
2014-11-03 22:52 ` [PATCH 07/12] tegra: tegra124: add serial alias nodes Lucas Stach
2014-11-03 22:52 ` [PATCH 08/12] tegra: jetson-tk1: add stdout-path Lucas Stach
2014-11-03 22:52 ` [PATCH 09/12] serial: ns16550: enable clock if available Lucas Stach
2014-11-03 22:52 ` [PATCH 10/12] serial: ns16550: add Tegra support Lucas Stach
2014-11-03 22:52 ` Lucas Stach [this message]
2014-11-03 22:52 ` [PATCH 12/12] clk: tegra: don't enable UART clocks by default Lucas Stach
2014-11-04 9:14 ` [PATCH 01/12] tegra: beaver: set hostname in board init Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415055144-6119-11-git-send-email-dev@lynxeye.de \
--to=dev@lynxeye.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox