mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Lucas Stach <l.stach@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH 03/20] firmware: altera-serial: don't try to check void return value
Date: Mon, 24 Nov 2014 12:06:43 +0100	[thread overview]
Message-ID: <1416827220-3103-4-git-send-email-l.stach@pengutronix.de> (raw)
In-Reply-To: <1416827220-3103-1-git-send-email-l.stach@pengutronix.de>

Fixes:
.../altera_serial.c:84:6: error: void value not ignored as it ought to be

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 drivers/firmware/altera_serial.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/firmware/altera_serial.c b/drivers/firmware/altera_serial.c
index 23ba3b00a478..232f1a682619 100644
--- a/drivers/firmware/altera_serial.c
+++ b/drivers/firmware/altera_serial.c
@@ -81,9 +81,7 @@ static int altera_spi_open(struct firmware_handler *fh)
 	}
 
 	/* arm the FPGA to await its new firmware */
-	ret = gpio_set_value(this->nconfig_gpio, 1);
-	if (ret)
-		return ret;
+	gpio_set_value(this->nconfig_gpio, 1);
 
 	/* once again, we might need padding the data */
 	this->padding_done = false;
-- 
2.1.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2014-11-24 11:07 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-24 11:06 [PATCH 00/20] First batch of randconfig fixes Lucas Stach
2014-11-24 11:06 ` [PATCH 01/20] firmware: socfpga: depend on ARCH_SOCFPGA Lucas Stach
2014-11-24 11:06 ` [PATCH 02/20] firmware: altera-serial: depend on SPI Lucas Stach
2014-11-24 11:06 ` Lucas Stach [this message]
2014-11-24 11:06 ` [PATCH 04/20] firmware: altera-serial: fix printf message Lucas Stach
2014-11-24 11:06 ` [PATCH 05/20] common: firmware: include libfile Lucas Stach
2014-11-24 11:06 ` [PATCH 06/20] arm: imx: select MFD_MC13XXX for all boards that need it Lucas Stach
2014-11-24 11:06 ` [PATCH 07/20] arm: imx: select I2C for all boards that need it in their board init Lucas Stach
2014-11-24 11:06 ` [PATCH 08/20] arm: imx: pca100: select USB ULPI support Lucas Stach
2014-11-24 12:48   ` Sascha Hauer
2014-11-24 11:06 ` [PATCH 09/20] arm: imx: nand update handler depends on MTD layer Lucas Stach
2014-11-24 11:06 ` [PATCH 10/20] arm: imx: properly stub out NAND bbu handler Lucas Stach
2014-11-24 12:50   ` Sascha Hauer
2014-11-24 11:06 ` [PATCH 11/20] arm: phyflex-imx6: move common.h before other includes Lucas Stach
2014-11-24 12:52   ` Sascha Hauer
2014-11-24 11:06 ` [PATCH 12/20] video: ipuv3: select OFDEVICE for HDMI and LVDS Lucas Stach
2014-11-24 11:06 ` [PATCH 13/20] mci: esdhc: add back PIO_TIMEOUT Lucas Stach
2014-11-24 11:06 ` [PATCH 14/20] arm: don't allow to select BUILTIN_DTB when building multiimage Lucas Stach
2014-11-24 11:06 ` [PATCH 15/20] arm: fill BUILTIN_DTB_NAME for boards that still use this option Lucas Stach
2014-11-24 11:06 ` [PATCH 16/20] net: ethoc: depend on OPENRISC Lucas Stach
2014-11-24 12:57   ` Sascha Hauer
2014-11-24 11:06 ` [PATCH 17/20] blspec: depend on, not select flexible bootargs Lucas Stach
2014-11-24 12:59   ` Sascha Hauer
2014-11-25 17:00     ` Lucas Stach
2014-11-24 11:06 ` [PATCH 18/20] common: menu needs PROCESS_ESCAPE_SEQUENCE Lucas Stach
2014-11-24 11:06 ` [PATCH 19/20] usb: gadget: fastboot: select BANNER Lucas Stach
2014-11-24 11:07 ` [PATCH 20/20] lib: decompress_xz: fix function header to match prototype Lucas Stach
2014-11-24 13:03 ` [PATCH 00/20] First batch of randconfig fixes Sascha Hauer
2014-11-26 19:59 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1416827220-3103-4-git-send-email-l.stach@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox