From: Lucas Stach <l.stach@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 17/20] blspec: depend on, not select flexible bootargs
Date: Tue, 25 Nov 2014 18:00:53 +0100 [thread overview]
Message-ID: <1416934853.2741.7.camel@pengutronix.de> (raw)
In-Reply-To: <20141124125931.GH30369@pengutronix.de>
Am Montag, den 24.11.2014, 13:59 +0100 schrieb Sascha Hauer:
> On Mon, Nov 24, 2014 at 12:06:57PM +0100, Lucas Stach wrote:
> > Blspec is a consumer of the flexible bootargs mechanism, so it should
> > depend on it rather than select it.
> >
> > Fixes:
> > warning: (BLSPEC && DEFAULT_ENVIRONMENT_GENERIC_NEW) selects FLEXIBLE_BOOTARGS
> > which has unmet direct dependencies (COMMAND_SUPPORT && CMD_GLOBAL)
> >
> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > ---
> > common/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/common/Kconfig b/common/Kconfig
> > index a2cce391f461..6583aabc44d9 100644
> > --- a/common/Kconfig
> > +++ b/common/Kconfig
> > @@ -478,8 +478,8 @@ config TIMESTAMP
> >
> > config BLSPEC
> > depends on BLOCK
> > + depends on FLEXIBLE_BOOTARGS
> > select OFTREE
> > - select FLEXIBLE_BOOTARGS
>
> This effectively disables BLSPEC support in these configs:
>
> arch/arm/configs/tegra_v7_defconfig:17:CONFIG_BLSPEC=y
> arch/arm/configs/rpi_defconfig:14:CONFIG_BLSPEC=y
> arch/arm/configs/imx_defconfig:22:CONFIG_BLSPEC=y
> arch/arm/configs/imx_v7_defconfig:40:CONFIG_BLSPEC=y
> arch/arm/configs/mvebu_defconfig:18:CONFIG_BLSPEC=y
> arch/arm/configs/am335x_defconfig:25:CONFIG_BLSPEC=y
> arch/arm/configs/tqma53_defconfig:19:CONFIG_BLSPEC=y
>
> You have to add a CONFIG_FLEXIBLE_BOOTARGS=y in these files.
>
Thanks for the pointer, I've looked into this and it seems this is only
necessary for the mvebu defconfig.
All other defconfigs include CONFIG_DEFAULT_ENVIRONMENT_GENERIC_NEW
which still selects CONFIG_FLEXIBLE_BOOTARGS. Will fix with v2.
Regards,
Lucas
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-11-25 17:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 11:06 [PATCH 00/20] First batch of randconfig fixes Lucas Stach
2014-11-24 11:06 ` [PATCH 01/20] firmware: socfpga: depend on ARCH_SOCFPGA Lucas Stach
2014-11-24 11:06 ` [PATCH 02/20] firmware: altera-serial: depend on SPI Lucas Stach
2014-11-24 11:06 ` [PATCH 03/20] firmware: altera-serial: don't try to check void return value Lucas Stach
2014-11-24 11:06 ` [PATCH 04/20] firmware: altera-serial: fix printf message Lucas Stach
2014-11-24 11:06 ` [PATCH 05/20] common: firmware: include libfile Lucas Stach
2014-11-24 11:06 ` [PATCH 06/20] arm: imx: select MFD_MC13XXX for all boards that need it Lucas Stach
2014-11-24 11:06 ` [PATCH 07/20] arm: imx: select I2C for all boards that need it in their board init Lucas Stach
2014-11-24 11:06 ` [PATCH 08/20] arm: imx: pca100: select USB ULPI support Lucas Stach
2014-11-24 12:48 ` Sascha Hauer
2014-11-24 11:06 ` [PATCH 09/20] arm: imx: nand update handler depends on MTD layer Lucas Stach
2014-11-24 11:06 ` [PATCH 10/20] arm: imx: properly stub out NAND bbu handler Lucas Stach
2014-11-24 12:50 ` Sascha Hauer
2014-11-24 11:06 ` [PATCH 11/20] arm: phyflex-imx6: move common.h before other includes Lucas Stach
2014-11-24 12:52 ` Sascha Hauer
2014-11-24 11:06 ` [PATCH 12/20] video: ipuv3: select OFDEVICE for HDMI and LVDS Lucas Stach
2014-11-24 11:06 ` [PATCH 13/20] mci: esdhc: add back PIO_TIMEOUT Lucas Stach
2014-11-24 11:06 ` [PATCH 14/20] arm: don't allow to select BUILTIN_DTB when building multiimage Lucas Stach
2014-11-24 11:06 ` [PATCH 15/20] arm: fill BUILTIN_DTB_NAME for boards that still use this option Lucas Stach
2014-11-24 11:06 ` [PATCH 16/20] net: ethoc: depend on OPENRISC Lucas Stach
2014-11-24 12:57 ` Sascha Hauer
2014-11-24 11:06 ` [PATCH 17/20] blspec: depend on, not select flexible bootargs Lucas Stach
2014-11-24 12:59 ` Sascha Hauer
2014-11-25 17:00 ` Lucas Stach [this message]
2014-11-24 11:06 ` [PATCH 18/20] common: menu needs PROCESS_ESCAPE_SEQUENCE Lucas Stach
2014-11-24 11:06 ` [PATCH 19/20] usb: gadget: fastboot: select BANNER Lucas Stach
2014-11-24 11:07 ` [PATCH 20/20] lib: decompress_xz: fix function header to match prototype Lucas Stach
2014-11-24 13:03 ` [PATCH 00/20] First batch of randconfig fixes Sascha Hauer
2014-11-26 19:59 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416934853.2741.7.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox