* [PATCH] commands: fix a warning in help.c
@ 2015-01-13 6:24 Masahiro Yamada
2015-01-13 7:56 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2015-01-13 6:24 UTC (permalink / raw)
To: barebox
Fix the following warning:
commands/help.c: In function ‘list_group’:
commands/help.c:57:4: warning: format not a string literal and
no format arguments [-Wformat-security]
printf(cmdtp->name);
^
Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
---
commands/help.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/commands/help.c b/commands/help.c
index 8985335..6e61bde 100644
--- a/commands/help.c
+++ b/commands/help.c
@@ -54,7 +54,7 @@ static void list_group(int verbose, const char *grpname, uint32_t group)
printf(", ");
pos += 2;
}
- printf(cmdtp->name);
+ puts(cmdtp->name);
pos += len;
}
}
--
1.9.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] commands: fix a warning in help.c
2015-01-13 6:24 [PATCH] commands: fix a warning in help.c Masahiro Yamada
@ 2015-01-13 7:56 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2015-01-13 7:56 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: barebox
On Tue, Jan 13, 2015 at 03:24:33PM +0900, Masahiro Yamada wrote:
> Fix the following warning:
>
> commands/help.c: In function ‘list_group’:
> commands/help.c:57:4: warning: format not a string literal and
> no format arguments [-Wformat-security]
> printf(cmdtp->name);
> ^
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-13 7:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-13 6:24 [PATCH] commands: fix a warning in help.c Masahiro Yamada
2015-01-13 7:56 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox