[PATCH] debug_ll: change the argument type of putc_ll()

[PATCH] debug_ll: change the argument type of putc_ll()

[Masahiro Yamada]

Most of the implementations of PUTC_LL() takes "char"
(some take "int"), not "unsigned char".
Moreover, puts_ll() takes an argument with "const char *" type.

Let's drop "unsigned" from the prototype of putc_ll().

Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
---

 include/debug_ll.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/debug_ll.h b/include/debug_ll.h
index 288aa25..b0eb7cd 100644
--- a/include/debug_ll.h
+++ b/include/debug_ll.h
@@ -33,7 +33,7 @@
 
 #if defined (CONFIG_DEBUG_LL)
 
-static inline void putc_ll(unsigned char value)
+static inline void putc_ll(char value)
 {
 	PUTC_LL(value);
 }
@@ -67,7 +67,7 @@ static inline void puts_ll(const char * str)
 
 #else
 
-static inline void putc_ll(unsigned char value)
+static inline void putc_ll(char value)
 {
 }
 
-- 
1.9.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] debug_ll: change the argument type of putc_ll()

[Sascha Hauer]

On Wed, Jan 21, 2015 at 01:36:08PM +0900, Masahiro Yamada wrote:
> Most of the implementations of PUTC_LL() takes "char"
> (some take "int"), not "unsigned char".
> Moreover, puts_ll() takes an argument with "const char *" type.
> 
> Let's drop "unsigned" from the prototype of putc_ll().
> 
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>

Applied, thanks.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox