From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YKoAh-0002RP-N4 for barebox@lists.infradead.org; Mon, 09 Feb 2015 13:14:40 +0000 Received: from weser.hi.pengutronix.de ([2001:67c:670:100:fa0f:41ff:fe58:4010]) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1YKoAJ-0000Lp-N1 for barebox@lists.infradead.org; Mon, 09 Feb 2015 14:14:15 +0100 Message-ID: <1423487655.10796.0.camel@pengutronix.de> From: Lucas Stach Date: Mon, 09 Feb 2015 14:14:15 +0100 In-Reply-To: <1418813891-24169-1-git-send-email-l.stach@pengutronix.de> References: <1418813891-24169-1-git-send-email-l.stach@pengutronix.de> Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH v2] imd: provide dummy imd_command_setenv To: barebox@lists.infradead.org Ping. :) Am Mittwoch, den 17.12.2014, 11:58 +0100 schrieb Lucas Stach: > If CONFIG_CMD_IMD is not set there is no imd_command_setenv in the > barebox binary that can be linked to. Although the whole imd infrastructure > will be removed by the linker later in the build process as soon as it > figures out that nothing inside barebox is using it, we still have to > provide a dummy function to keep the build going. > > Fixes: > In function `imd_command': undefined reference to `imd_command_setenv' > > Signed-off-by: Lucas Stach > --- > v2: move dummy to correct location > --- > common/imd.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/common/imd.c b/common/imd.c > index 2c837d6f256e..f84e34473e69 100644 > --- a/common/imd.c > +++ b/common/imd.c > @@ -22,6 +22,13 @@ > #include > #include > #include > + > +#ifndef CONFIG_CMD_IMD > +int imd_command_setenv(const char *variable_name, const char *value) > +{ > + return -ENOSYS; > +} > +#endif > #endif > > /* -- Pengutronix e.K. | Lucas Stach | Industrial Linux Solutions | http://www.pengutronix.de/ | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox