From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH 09/17] cmdlinepart: make argument types safer
Date: Thu, 12 Feb 2015 09:54:26 +0100 [thread overview]
Message-ID: <1423731274-9860-10-git-send-email-s.hauer@pengutronix.de> (raw)
In-Reply-To: <1423731274-9860-1-git-send-email-s.hauer@pengutronix.de>
The return size should be loff_t to support partitions bigger
than 4G. Also use const for the devname and endp.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
commands/partition.c | 4 ++--
include/cmdlinepart.h | 6 +++---
lib/cmdlinepart.c | 6 +++---
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/commands/partition.c b/commands/partition.c
index c95433f..17ca136 100644
--- a/commands/partition.c
+++ b/commands/partition.c
@@ -41,7 +41,7 @@
static int do_addpart(int argc, char *argv[])
{
char *devname;
- char *endp;
+ const char *endp;
loff_t offset = 0;
loff_t devsize;
struct stat s;
@@ -70,7 +70,7 @@ static int do_addpart(int argc, char *argv[])
endp = argv[optind + 1];
while (1) {
- size_t size = 0;
+ loff_t size = 0;
if (cmdlinepart_do_parse_one(devname, endp, &endp, &offset,
devsize, &size, flags))
diff --git a/include/cmdlinepart.h b/include/cmdlinepart.h
index 5ffa3c4..3f8e136 100644
--- a/include/cmdlinepart.h
+++ b/include/cmdlinepart.h
@@ -3,9 +3,9 @@
#define CMDLINEPART_ADD_DEVNAME (1 << 0)
-int cmdlinepart_do_parse_one(char *devname, const char *partstr,
- char **endp, loff_t *offset,
- loff_t devsize, size_t *retsize,
+int cmdlinepart_do_parse_one(const char *devname, const char *partstr,
+ const char **endp, loff_t *offset,
+ loff_t devsize, loff_t *retsize,
unsigned int partition_flags);
#endif /* __CMD_LINE_PART_H */
diff --git a/lib/cmdlinepart.c b/lib/cmdlinepart.c
index 4781d82..9351587 100644
--- a/lib/cmdlinepart.c
+++ b/lib/cmdlinepart.c
@@ -24,9 +24,9 @@
#define SIZE_REMAINING ((loff_t)-1)
-int cmdlinepart_do_parse_one(char *devname, const char *partstr,
- char **endp, loff_t *offset,
- loff_t devsize, size_t *retsize,
+int cmdlinepart_do_parse_one(const char *devname, const char *partstr,
+ const char **endp, loff_t *offset,
+ loff_t devsize, loff_t *retsize,
unsigned int partition_flags)
{
loff_t size;
--
2.1.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-02-12 8:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 8:54 mtd partition handling updates Sascha Hauer
2015-02-12 8:54 ` [PATCH 01/17] of: Add for_each_child_of_node_safe Sascha Hauer
2015-02-12 8:54 ` [PATCH 02/17] mtd: core: add error checks Sascha Hauer
2015-02-12 8:54 ` [PATCH 03/17] mtd: partitions: Use xstrdup Sascha Hauer
2015-02-12 8:54 ` [PATCH 04/17] mtd: partitions: Add error check Sascha Hauer
2015-02-12 8:54 ` [PATCH 05/17] mtd: Add partitions to list Sascha Hauer
2015-02-12 8:54 ` [PATCH 06/17] mtd: nand: remove automatically created bb devices Sascha Hauer
2015-02-12 8:54 ` [PATCH 07/17] move cmdline partition parsing code to separate file Sascha Hauer
2015-02-12 8:54 ` [PATCH 08/17] cmdlinepart: Change SIZE_REMAINING to loff_t Sascha Hauer
2015-02-12 8:54 ` Sascha Hauer [this message]
2015-02-12 8:54 ` [PATCH 10/17] cmdlinepart: add function to parse a cmdline partition string Sascha Hauer
2015-02-12 8:54 ` [PATCH 11/17] cmndlinepart: skip devname if partstr already contains it Sascha Hauer
2015-02-12 8:54 ` [PATCH 12/17] mtd: forbid conflicting mtd partitions Sascha Hauer
2015-02-12 8:54 ` [PATCH 13/17] mtd: Use flags parameter in mtd_add_partition Sascha Hauer
2015-02-12 8:54 ` [PATCH 14/17] mtd: Add a partitions parameter to mtd devices Sascha Hauer
2015-02-12 8:54 ` [PATCH 15/17] mtd: fixup device tree partitions Sascha Hauer
2015-02-12 8:54 ` [PATCH 16/17] defaultenv-2: mtdparts-add: remove unused variable Sascha Hauer
2015-02-12 8:54 ` [PATCH 17/17] defaultenv-2: mtdparts-add: Use new partition parameter Sascha Hauer
2015-02-13 5:54 ` mtd partition handling updates Bo Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423731274-9860-10-git-send-email-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox