* [PATCH 1/3] net: designware: don't depend on CONFIG_OFTREE
@ 2015-03-01 21:06 Lucas Stach
2015-03-01 21:06 ` [PATCH 2/3] menu: depend on !CONFIG_SHELL_NONE Lucas Stach
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Lucas Stach @ 2015-03-01 21:06 UTC (permalink / raw)
To: barebox
This driver is written in a way that is should also work without
DT, but it had a compile time dependency on CONFIG_OFTREE.
Fixes:
drivers/built-in.o: In function `dwc_probe_dt':
drivers/net/designware.c:413: undefined reference to `of_get_phy_mode'
Signed-off-by: Lucas Stach <dev@lynxeye.de>
---
drivers/net/designware.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/designware.c b/drivers/net/designware.c
index 49ed0b192231..29a6047c7f1a 100644
--- a/drivers/net/designware.c
+++ b/drivers/net/designware.c
@@ -406,6 +406,9 @@ static void dwc_version(struct device_d *dev, u32 hwid)
static int dwc_probe_dt(struct device_d *dev, struct dw_eth_dev *priv)
{
+ if (!IS_ENABLED(CONFIG_OFTREE))
+ return -ENODEV;
+
priv->phy_addr = -1;
priv->interface = of_get_phy_mode(dev->device_node);
--
2.1.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH 2/3] menu: depend on !CONFIG_SHELL_NONE
2015-03-01 21:06 [PATCH 1/3] net: designware: don't depend on CONFIG_OFTREE Lucas Stach
@ 2015-03-01 21:06 ` Lucas Stach
2015-03-01 21:06 ` [PATCH 3/3] ARM: MIOA701: select POLLER Lucas Stach
2015-03-02 6:35 ` [PATCH 1/3] net: designware: don't depend on CONFIG_OFTREE Sascha Hauer
2 siblings, 0 replies; 4+ messages in thread
From: Lucas Stach @ 2015-03-01 21:06 UTC (permalink / raw)
To: barebox
It doesn't make much sense to have the menuframework but no
shell.
Fixes:
In function `menu_action_command': undefined reference to `run_command'
Signed-off-by: Lucas Stach <dev@lynxeye.de>
---
common/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/common/Kconfig b/common/Kconfig
index d4373431aae8..cf197076dbab 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -414,6 +414,7 @@ config AUTO_COMPLETE
config MENU
bool
prompt "Menu Framework"
+ depends on !SHELL_NONE
select PROCESS_ESCAPE_SEQUENCE
help
a menu framework that allow us to create list menu to simplify
--
2.1.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 3/3] ARM: MIOA701: select POLLER
2015-03-01 21:06 [PATCH 1/3] net: designware: don't depend on CONFIG_OFTREE Lucas Stach
2015-03-01 21:06 ` [PATCH 2/3] menu: depend on !CONFIG_SHELL_NONE Lucas Stach
@ 2015-03-01 21:06 ` Lucas Stach
2015-03-02 6:35 ` [PATCH 1/3] net: designware: don't depend on CONFIG_OFTREE Sascha Hauer
2 siblings, 0 replies; 4+ messages in thread
From: Lucas Stach @ 2015-03-01 21:06 UTC (permalink / raw)
To: barebox
Fixes:
In function `gpio0_poweroff_probe': undefined reference to `poller_register'
Signed-off-by: Lucas Stach <dev@lynxeye.de>
---
arch/arm/mach-pxa/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-pxa/Kconfig b/arch/arm/mach-pxa/Kconfig
index a45e01a70222..67d1f4b5a9d4 100644
--- a/arch/arm/mach-pxa/Kconfig
+++ b/arch/arm/mach-pxa/Kconfig
@@ -64,6 +64,7 @@ config MACH_MIOA701
bool "Mitac Mio A701"
select BCH_CONST_PARAMS
select PWM
+ select POLLER
help
Say Y here if you are using a Mitac Mio A701 smartphone
--
2.1.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] net: designware: don't depend on CONFIG_OFTREE
2015-03-01 21:06 [PATCH 1/3] net: designware: don't depend on CONFIG_OFTREE Lucas Stach
2015-03-01 21:06 ` [PATCH 2/3] menu: depend on !CONFIG_SHELL_NONE Lucas Stach
2015-03-01 21:06 ` [PATCH 3/3] ARM: MIOA701: select POLLER Lucas Stach
@ 2015-03-02 6:35 ` Sascha Hauer
2 siblings, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2015-03-02 6:35 UTC (permalink / raw)
To: Lucas Stach; +Cc: barebox
On Sun, Mar 01, 2015 at 10:06:35PM +0100, Lucas Stach wrote:
> This driver is written in a way that is should also work without
> DT, but it had a compile time dependency on CONFIG_OFTREE.
>
> Fixes:
> drivers/built-in.o: In function `dwc_probe_dt':
> drivers/net/designware.c:413: undefined reference to `of_get_phy_mode'
>
> Signed-off-by: Lucas Stach <dev@lynxeye.de>
> ---
> drivers/net/designware.c | 3 +++
> 1 file changed, 3 insertions(+)
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-02 6:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-01 21:06 [PATCH 1/3] net: designware: don't depend on CONFIG_OFTREE Lucas Stach
2015-03-01 21:06 ` [PATCH 2/3] menu: depend on !CONFIG_SHELL_NONE Lucas Stach
2015-03-01 21:06 ` [PATCH 3/3] ARM: MIOA701: select POLLER Lucas Stach
2015-03-02 6:35 ` [PATCH 1/3] net: designware: don't depend on CONFIG_OFTREE Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox