[PATCH] make PBL_CONSOLE depend on PBL_IMAGE

[PATCH] make PBL_CONSOLE depend on PBL_IMAGE

[Antony Pavlov]

PBL_CONSOLE option is used only for building PBL. See this output:

    barebox$ git grep PBL_CONSOLE
    arch/arm/configs/tx28stk5_defconfig:CONFIG_PBL_CONSOLE=y
    common/Kconfig:config PBL_CONSOLE
    common/Makefile:pbl-$(CONFIG_PBL_CONSOLE)       += memory_display.o
    include/printk.h:       (defined(__PBL__) && defined(CONFIG_PBL_CONSOLE))
    include/stdio.h:        (defined(__PBL__) && defined(CONFIG_PBL_CONSOLE))
    lib/Makefile:pbl-$(CONFIG_PBL_CONSOLE) += vsprintf.o
    pbl/Makefile:pbl-$(CONFIG_PBL_CONSOLE) += console.o

PBL_CONSOLE looks confusing in PBL-less configuration
so it's better to enable it only if PBL is enabled.

Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
---
 common/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/common/Kconfig b/common/Kconfig
index d6a1fa7..15e581c 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -923,6 +923,7 @@ config DEBUG_INITCALLS
 	  If enabled this will print initcall traces.
 
 config PBL_CONSOLE
+	depends on PBL_IMAGE
 	depends on DEBUG_LL
 	depends on !CONSOLE_NONE
 	bool "Enable console support in PBL"
-- 
2.1.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] make PBL_CONSOLE depend on PBL_IMAGE

[Sascha Hauer]

On Sat, Apr 04, 2015 at 05:03:17PM +0300, Antony Pavlov wrote:
> PBL_CONSOLE option is used only for building PBL. See this output:
> 
>     barebox$ git grep PBL_CONSOLE
>     arch/arm/configs/tx28stk5_defconfig:CONFIG_PBL_CONSOLE=y
>     common/Kconfig:config PBL_CONSOLE
>     common/Makefile:pbl-$(CONFIG_PBL_CONSOLE)       += memory_display.o
>     include/printk.h:       (defined(__PBL__) && defined(CONFIG_PBL_CONSOLE))
>     include/stdio.h:        (defined(__PBL__) && defined(CONFIG_PBL_CONSOLE))
>     lib/Makefile:pbl-$(CONFIG_PBL_CONSOLE) += vsprintf.o
>     pbl/Makefile:pbl-$(CONFIG_PBL_CONSOLE) += console.o
> 
> PBL_CONSOLE looks confusing in PBL-less configuration
> so it's better to enable it only if PBL is enabled.
> 
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
>  common/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox