[PATCH 1/2] environment: remove unused code

[PATCH 1/2] environment: remove unused code

[Marc Kleine-Budde]

This patch removes the LIST_HEAD of_partition_list and a struct definition from
the code. This was present but unused, since the file was added to barebox.

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
 drivers/of/barebox.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/of/barebox.c b/drivers/of/barebox.c
index 224674240e7c..0220bc6b3123 100644
--- a/drivers/of/barebox.c
+++ b/drivers/of/barebox.c
@@ -26,15 +26,6 @@
 #include <envfs.h>
 #include <linux/mtd/mtd.h>
 
-struct of_partition {
-	struct list_head list;
-	char *nodepath;
-	struct device_d *dev;
-	struct device_node *of_partitions;
-};
-
-static LIST_HEAD(of_partition_list);
-
 static int environment_probe(struct device_d *dev)
 {
 	char *path;
-- 
2.1.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 2/2] include: add includes includes to make fdt.h, of.h and state.h self contained

[Marc Kleine-Budde]

Otherwise compilation may fail with:

include/fdt.h:11:15: error: unknown type name 'uint64_t'
 static inline uint64_t fdt64_to_cpu(uint64_t x)

include/of.h:22:19: error: field 'list' has incomplete type
  struct list_head list;

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
 include/fdt.h   | 2 ++
 include/of.h    | 2 ++
 include/state.h | 2 ++
 3 files changed, 6 insertions(+)

diff --git a/include/fdt.h b/include/fdt.h
index 35278e30304b..1ccd4c67344a 100644
--- a/include/fdt.h
+++ b/include/fdt.h
@@ -1,6 +1,8 @@
 #ifndef _FDT_H
 #define _FDT_H
 
+#include <linux/types.h>
+
 #ifndef __ASSEMBLY__
 
 #define _B(n)	((unsigned long long)((uint8_t *)&x)[n])
diff --git a/include/of.h b/include/of.h
index 764a2e5939b7..7235138f30bf 100644
--- a/include/of.h
+++ b/include/of.h
@@ -3,6 +3,8 @@
 
 #include <fdt.h>
 #include <errno.h>
+#include <linux/types.h>
+#include <linux/list.h>
 #include <asm/byteorder.h>
 
 /* Default string compare functions */
diff --git a/include/state.h b/include/state.h
index 95bf8d263b19..e96d3bfb2e4f 100644
--- a/include/state.h
+++ b/include/state.h
@@ -1,6 +1,8 @@
 #ifndef __STATE_H
 #define __STATE_H
 
+#include <of.h>
+
 struct state;
 
 int state_backend_dtb_file(struct state *state, const char *path);
-- 
2.1.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 1/2] environment: remove unused code

[Sascha Hauer]

On Wed, Apr 15, 2015 at 10:43:59PM +0200, Marc Kleine-Budde wrote:
> This patch removes the LIST_HEAD of_partition_list and a struct definition from
> the code. This was present but unused, since the file was added to barebox.
> 
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---
>  drivers/of/barebox.c | 9 ---------
>  1 file changed, 9 deletions(-)

Applied, thanks

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox