From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH 12/12] loadb: ignore -c option
Date: Tue, 9 Jun 2015 08:21:15 +0200 [thread overview]
Message-ID: <1433830875-31119-13-git-send-email-s.hauer@pengutronix.de> (raw)
In-Reply-To: <1433830875-31119-1-git-send-email-s.hauer@pengutronix.de>
And always create the file if necessary. No need to have an extra flag for
this.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
commands/loadb.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/commands/loadb.c b/commands/loadb.c
index acc3cd4..be5830d 100644
--- a/commands/loadb.c
+++ b/commands/loadb.c
@@ -606,7 +606,6 @@ static int do_load_serial_bin(int argc, char *argv[])
int load_baudrate = 0, current_baudrate;
int rcode = 0, ret;
int opt;
- int open_mode = O_WRONLY;
char *output_file = NULL;
struct console_device *cdev = NULL;
@@ -621,9 +620,6 @@ static int do_load_serial_bin(int argc, char *argv[])
case 'o':
offset = (int)simple_strtoul(optarg, NULL, 10);
break;
- case 'c':
- open_mode |= O_CREAT;
- break;
default:
perror(argv[0]);
return 1;
@@ -644,7 +640,7 @@ static int do_load_serial_bin(int argc, char *argv[])
output_file = DEF_FILE;
/* File should exist */
- ofd = open(output_file, open_mode);
+ ofd = open(output_file, O_WRONLY | O_CREAT);
if (ofd < 0) {
perror(argv[0]);
return 3;
@@ -688,7 +684,6 @@ BAREBOX_CMD_HELP_TEXT("Options:")
BAREBOX_CMD_HELP_OPT("-f FILE", "download to FILE (default image.bin")
BAREBOX_CMD_HELP_OPT("-o OFFS", "destination file OFFSet (default 0)")
BAREBOX_CMD_HELP_OPT("-b BAUD", "baudrate for download (default: console baudrate")
-BAREBOX_CMD_HELP_OPT("-c", "create file if not present")
BAREBOX_CMD_HELP_END
BAREBOX_CMD_START(loadb)
--
2.1.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-06-09 6:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 6:21 Add functions for (de)activating consoles and for setting baudrate Sascha Hauer
2015-06-09 6:21 ` [PATCH 01/12] console: Add functions to get/set active state of console Sascha Hauer
2015-06-09 6:21 ` [PATCH 02/12] console: Add functions to get/set baudrate Sascha Hauer
2015-06-09 6:21 ` [PATCH 03/12] console: Add console_get_by_name Sascha Hauer
2015-06-09 6:21 ` [PATCH 04/12] console: When switching baudrate print console name Sascha Hauer
2015-06-09 6:21 ` [PATCH 05/12] usb: gadget: serial: Use console_set_active to activate console Sascha Hauer
2015-06-09 6:21 ` [PATCH 06/12] loadxy: Use console_get_by_name Sascha Hauer
2015-06-09 6:21 ` [PATCH 07/12] loadxy: use console_get_baudrate Sascha Hauer
2015-06-09 6:21 ` [PATCH 08/12] loadx: ignore -c option Sascha Hauer
2015-06-09 6:21 ` [PATCH 09/12] loadxy: use console_set_baudrate Sascha Hauer
2015-06-09 6:21 ` [PATCH 10/12] loadb: use console_get_baudrate Sascha Hauer
2015-06-09 6:21 ` [PATCH 11/12] loadb: Use console_set_baudrate Sascha Hauer
2015-06-09 6:21 ` Sascha Hauer [this message]
2015-06-09 7:26 ` Add functions for (de)activating consoles and for setting baudrate Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433830875-31119-13-git-send-email-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox