From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: barebox@lists.infradead.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
Subject: [PATCH] lib: libfile: Do not ignore errors in close()
Date: Sun, 12 Jul 2015 17:09:47 -0700 [thread overview]
Message-ID: <1436746187-8652-1-git-send-email-asmirnov@kymetacorp.com> (raw)
From: Andrey Smirnov <andrew.smirnov@gmail.com>
Some character devices may perform meaningful operations in their
implementation of close() -- a good example would be socfpga.c which
checks if the FPGA was programmed succesfully in it's close() method
-- so ignoring return value of this call may cause false positives in
checking exit status for success.
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
lib/libfile.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/libfile.c b/lib/libfile.c
index 8acff04..4f21e70 100644
--- a/lib/libfile.c
+++ b/lib/libfile.c
@@ -262,7 +262,7 @@ int copy_file(const char *src, const char *dst, int verbose)
char *rw_buf = NULL;
int srcfd = 0, dstfd = 0;
int r, w;
- int ret = 1;
+ int ret = 1, err1 = 0, err2 = 0;
void *buf;
int total = 0;
struct stat statbuf;
@@ -324,11 +324,11 @@ out:
free(rw_buf);
if (srcfd > 0)
- close(srcfd);
+ err1 = close(srcfd);
if (dstfd > 0)
- close(dstfd);
+ err2 = close(dstfd);
- return ret;
+ return ret ?: err1 ?: err2;
}
EXPORT_SYMBOL(copy_file);
--
2.1.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2015-07-13 0:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 0:09 Andrey Smirnov [this message]
2015-07-14 5:08 ` Sascha Hauer
2015-07-20 19:51 ` Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436746187-8652-1-git-send-email-asmirnov@kymetacorp.com \
--to=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox