mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Lucas Stach <l.stach@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH 1/4] usb: gadget: serial: only call into CONSOLE_FULL code if it's there
Date: Thu, 23 Jul 2015 11:56:50 +0200	[thread overview]
Message-ID: <1437645413-18057-1-git-send-email-l.stach@pengutronix.de> (raw)

From: Lucas Stach <dev@lynxeye.de>

Fixes:
drivers/built-in.o: In function `gserial_connect':
drivers/usb/gadget/u_serial.c:539: undefined reference to `console_set_active'

Signed-off-by: Lucas Stach <dev@lynxeye.de>
---
 drivers/usb/gadget/u_serial.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/gadget/u_serial.c b/drivers/usb/gadget/u_serial.c
index 2b0faf33037e..140346e77028 100644
--- a/drivers/usb/gadget/u_serial.c
+++ b/drivers/usb/gadget/u_serial.c
@@ -536,8 +536,9 @@ int gserial_connect(struct gserial *gser, u8 port_num)
 	if (status)
 		goto fail_out;
 
-	console_set_active(cdev, CONSOLE_STDIN | CONSOLE_STDOUT |
-		CONSOLE_STDERR);
+	if (IS_ENABLED(CONFIG_CONSOLE_FULL))
+		console_set_active(cdev, CONSOLE_STDIN | CONSOLE_STDOUT |
+				   CONSOLE_STDERR);
 
 	/* REVISIT if waiting on "carrier detect", signal. */
 
-- 
2.1.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2015-07-23  9:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-23  9:56 Lucas Stach [this message]
2015-07-23  9:56 ` [PATCH 2/4] ARM: pxa: move mainstone TEXTBASE to Kconfig Lucas Stach
2015-07-23  9:56 ` [PATCH 3/4] ARM: rockchip: depend on OFTREE Lucas Stach
2015-07-23  9:56 ` [PATCH 4/4] ARM: don't allow Thumb2 on AT91 Lucas Stach
2015-07-24  7:25 ` [PATCH 1/4] usb: gadget: serial: only call into CONSOLE_FULL code if it's there Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1437645413-18057-1-git-send-email-l.stach@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox