mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Jan Remmet <j.remmet@phytec.de>
To: barebox@lists.infradead.org
Subject: [PATCH] ubiformat: remove dead code
Date: Thu, 24 Sep 2015 16:28:18 +0200	[thread overview]
Message-ID: <1443104898-11695-1-git-send-email-j.remmet@phytec.de> (raw)

divisor isn't used.

Signed-off-by: Jan Remmet <j.remmet@phytec.de>
---
 commands/ubiformat.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/commands/ubiformat.c b/commands/ubiformat.c
index f9d952c..8516e11 100644
--- a/commands/ubiformat.c
+++ b/commands/ubiformat.c
@@ -297,7 +297,7 @@ static int mark_bad(const struct mtd_dev_info *mtd, struct ubi_scan_info *si, in
 static int flash_image(const struct mtd_dev_info *mtd,
 		       const struct ubigen_info *ui, struct ubi_scan_info *si)
 {
-	int fd, img_ebs, eb, written_ebs = 0, divisor, ret = -1;
+	int fd, img_ebs, eb, written_ebs = 0, ret = -1;
 	off_t st_size;
 	char *buf = NULL;
 
@@ -332,7 +332,6 @@ static int flash_image(const struct mtd_dev_info *mtd,
 	}
 
 	verbose(args.verbose, "will write %d eraseblocks", img_ebs);
-	divisor = img_ebs;
 	for (eb = 0; eb < mtd->eb_cnt; eb++) {
 		int err, new_len;
 		long long ec;
@@ -342,10 +341,8 @@ static int flash_image(const struct mtd_dev_info *mtd,
 			       eb, (eb + 1) * 100 / mtd->eb_cnt);
 		}
 
-		if (si->ec[eb] == EB_BAD) {
-			divisor += 1;
+		if (si->ec[eb] == EB_BAD)
 			continue;
-		}
 
 		if (args.verbose) {
 			normsg_cont("eraseblock %d: erase", eb);
-- 
1.9.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2015-09-24 14:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-24 14:28 Jan Remmet [this message]
2015-09-29  6:41 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443104898-11695-1-git-send-email-j.remmet@phytec.de \
    --to=j.remmet@phytec.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox