[PATCH] ARM: PXA: move HAVE_CLK select

[PATCH] ARM: PXA: move HAVE_CLK select

[Lucas Stach]

Claiming that all of PXA has CLK implemented, while only PXA3XX
selects the relevant clock implementations causes lots of build
failures for the other PXA architectures.

Fix it by moving the HAVE_CLK select to the one PXA arch, that
actually has it.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 arch/arm/Kconfig          | 1 -
 arch/arm/mach-pxa/Kconfig | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 71d4336d2a70..1fc887ba5971 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -161,7 +161,6 @@ config ARCH_PXA
 	bool "Intel/Marvell PXA based"
 	select GENERIC_GPIO
 	select HAS_POWEROFF
-	select HAVE_CLK
 
 config ARCH_ROCKCHIP
 	bool "Rockchip RX3xxx"
diff --git a/arch/arm/mach-pxa/Kconfig b/arch/arm/mach-pxa/Kconfig
index 1c0894892b17..06ad1885a622 100644
--- a/arch/arm/mach-pxa/Kconfig
+++ b/arch/arm/mach-pxa/Kconfig
@@ -17,6 +17,7 @@ config ARCH_PXA2XX
 config ARCH_PXA3XX
        bool
        select CPU_XSC3
+       select HAVE_CLK
        select CLKDEV_LOOKUP
        select COMMON_CLK
 
-- 
2.6.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] ARM: PXA: move HAVE_CLK select

[Sascha Hauer]

On Mon, Jan 18, 2016 at 11:19:20AM +0100, Lucas Stach wrote:
> Claiming that all of PXA has CLK implemented, while only PXA3XX
> selects the relevant clock implementations causes lots of build
> failures for the other PXA architectures.

I can't see any build failures here. which config/branch are you using?

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] ARM: PXA: move HAVE_CLK select

[Sascha Hauer]

On Tue, Jan 19, 2016 at 08:53:02AM +0100, Sascha Hauer wrote:
> On Mon, Jan 18, 2016 at 11:19:20AM +0100, Lucas Stach wrote:
> > Claiming that all of PXA has CLK implemented, while only PXA3XX
> > selects the relevant clock implementations causes lots of build
> > failures for the other PXA architectures.
> 
> I can't see any build failures here. which config/branch are you using?

Ok, Lucas told me: HAVE_CLK makes other code selectable which depends on
clk_* functions which are not available.

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox