From: "Uwe Kleine-König" <uwe@kleine-koenig.org>
To: barebox@lists.infradead.org
Subject: [PATCH] kwboot: do a filetype check before sending the image
Date: Wed, 20 Jan 2016 08:46:50 +0100 [thread overview]
Message-ID: <1453276010-4669-1-git-send-email-uwe@kleine-koenig.org> (raw)
Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
---
scripts/kwboot.c | 45 +++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 45 insertions(+)
diff --git a/scripts/kwboot.c b/scripts/kwboot.c
index 46328d8ed006..61f807d163f7 100644
--- a/scripts/kwboot.c
+++ b/scripts/kwboot.c
@@ -546,6 +546,49 @@ out:
return rc;
}
+static void
+kwboot_check_image(unsigned char *img, size_t size)
+{
+ size_t i;
+ size_t header_size, image_size;
+ unsigned char csum = 0;
+
+ switch (img[0x0]) {
+ case 0x5a: /* SPI/NOR */
+ case 0x69: /* UART0 */
+ case 0x78: /* SATA */
+ case 0x8b: /* NAND */
+ case 0x9c: /* PCIe */
+ break;
+ default:
+ printf("Unknown boot source: 0x%hhx\n", img[0x0]);
+ }
+
+ if (img[0x8] != 1)
+ printf("Unknown version: 0x%hhx\n", img[0x8]);
+
+ image_size = img[0x4] | (img[0x5] << 8) |
+ (img[0x6] << 16) | (img[0x7] << 24);
+
+ header_size = (img[0x9] << 16) | img[0xa] | (img[0xb] << 8);
+
+ if (header_size + image_size != size) {
+ printf("Size mismatch (%zu + %zu != %zu)\n",
+ header_size, image_size, size);
+ } else {
+ for (i = 0; i < header_size; ++i)
+ csum += img[i];
+
+ csum -= img[0x1f];
+
+ if (csum != img[0x1f])
+ printf("Checksum mismatch: header: 0x%02hhx, calculated: 0x%02hhx\n",
+ img[0x1f], csum);
+ }
+}
+
+
+
static void *
kwboot_mmap_image(const char *path, size_t *size, int prot)
{
@@ -574,6 +617,8 @@ kwboot_mmap_image(const char *path, size_t *size, int prot)
rc = 0;
*size = st.st_size;
+
+ kwboot_check_image(img, *size);
out:
if (rc && img) {
munmap(img, st.st_size);
--
2.7.0.rc3
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2016-01-20 7:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 7:46 Uwe Kleine-König [this message]
2016-01-20 7:56 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453276010-4669-1-git-send-email-uwe@kleine-koenig.org \
--to=uwe@kleine-koenig.org \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox