From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: barebox@lists.infradead.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>,
Andrey Gusakov <andrey.gusakov@cogentembedded.com>
Subject: [PATCH 3/7] miitool: Fix PHY argument handling
Date: Mon, 25 Jan 2016 21:55:54 -0800 [thread overview]
Message-ID: <1453787758-12688-3-git-send-email-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <1453787758-12688-1-git-send-email-andrew.smirnov@gmail.com>
Instead of displaying the status of PHY "PHY" the tool will print status
of all PHYs it encounters while searching for the one that was
requested. This commit fixes the logic such that only requested
information is printed.
Signed-off-by: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
commands/miitool.c | 25 +++++++++++++++++--------
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/commands/miitool.c b/commands/miitool.c
index c62e758..9ee3597 100644
--- a/commands/miitool.c
+++ b/commands/miitool.c
@@ -233,18 +233,27 @@ static void mdiobus_show(struct device_d *dev, char *phydevname, int verbose)
struct phy_device *phydev;
phydev = mdiobus_scan(mii, i);
- if (IS_ERR(phydev))
+ if (IS_ERR(phydev) || !phydev->registered)
continue;
- if (phydev->registered) {
- show_basic_mii(mii, phydev, verbose);
+ /*
+ * If we are looking for a secific phy, called
+ * 'phydevname', but current phydev is not it, skip to
+ * the next iteration
+ */
+ if (phydevname &&
+ strcmp(phydev->cdev.name, phydevname))
+ continue;
- if (phydevname &&
- !strcmp(phydev->cdev.name, phydevname)) {
- return;
- }
- }
+ show_basic_mii(mii, phydev, verbose);
+ /*
+ * We were looking for a specific device and at this
+ * point we already shown the info about it so end the
+ * loop and exit
+ */
+ if (phydevname)
+ break;
}
return;
--
2.5.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2016-01-26 5:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 5:55 [PATCH 1/7] include/linux/phy.h: Add MII_ADDR_C45 Andrey Smirnov
2016-01-26 5:55 ` [PATCH 2/7] net: Port bitbanged MDIO code from Linux kernel Andrey Smirnov
2016-01-26 5:55 ` Andrey Smirnov [this message]
2016-01-26 5:55 ` [PATCH 4/7] mdio_bus: Change dev_info to dev_dbg Andrey Smirnov
2016-01-26 5:55 ` [PATCH 5/7] mdio_bus: Add mdiobus_get_bus() function Andrey Smirnov
2016-01-26 5:55 ` [PATCH 6/7] miitool: Don't print negative parent IDs Andrey Smirnov
2016-01-26 5:55 ` [PATCH 7/7] commands: Add mdio_read and mdio_write Andrey Smirnov
2016-01-26 21:55 ` Sascha Hauer
2016-01-27 2:09 ` Andrey Smirnov
2016-01-27 2:29 ` Trent Piepho
2016-01-27 7:19 ` Sascha Hauer
2016-01-27 7:26 ` Sascha Hauer
2016-01-28 18:00 ` Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453787758-12688-3-git-send-email-andrew.smirnov@gmail.com \
--to=andrew.smirnov@gmail.com \
--cc=andrey.gusakov@cogentembedded.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox