* scripts/remote: make clean leftovers
@ 2016-01-26 10:04 Yegor Yefremov
2016-01-26 10:49 ` Jan Lübbe
0 siblings, 1 reply; 4+ messages in thread
From: Yegor Yefremov @ 2016-01-26 10:04 UTC (permalink / raw)
To: barebox
After performing make distclean I've discovered following files being removed:
Changes not staged for commit:
(use "git add/rm <file>..." to update what will be committed)
(use "git checkout -- <file>..." to discard changes in working directory)
deleted: scripts/remote/__init__.py
deleted: scripts/serial/tools/__init__.py
deleted: scripts/serial/urlhandler/__init__.py
What should actually happen to these files?
Yegor
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: scripts/remote: make clean leftovers
2016-01-26 10:04 scripts/remote: make clean leftovers Yegor Yefremov
@ 2016-01-26 10:49 ` Jan Lübbe
2016-02-03 7:55 ` Sascha Hauer
0 siblings, 1 reply; 4+ messages in thread
From: Jan Lübbe @ 2016-01-26 10:49 UTC (permalink / raw)
To: barebox
On Di, 2016-01-26 at 11:04 +0100, Yegor Yefremov wrote:
> After performing make distclean I've discovered following files being removed:
>
> Changes not staged for commit:
> (use "git add/rm <file>..." to update what will be committed)
> (use "git checkout -- <file>..." to discard changes in working directory)
>
> deleted: scripts/remote/__init__.py
> deleted: scripts/serial/tools/__init__.py
> deleted: scripts/serial/urlhandler/__init__.py
>
> What should actually happen to these files?
Python uses these files to recognize the directory as containing a
module, so we need to keep them.
Regards,
Jan
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: scripts/remote: make clean leftovers
2016-01-26 10:49 ` Jan Lübbe
@ 2016-02-03 7:55 ` Sascha Hauer
2016-02-03 8:58 ` Jan Lübbe
0 siblings, 1 reply; 4+ messages in thread
From: Sascha Hauer @ 2016-02-03 7:55 UTC (permalink / raw)
To: Jan Lübbe; +Cc: barebox
On Tue, Jan 26, 2016 at 11:49:09AM +0100, Jan Lübbe wrote:
> On Di, 2016-01-26 at 11:04 +0100, Yegor Yefremov wrote:
> > After performing make distclean I've discovered following files being removed:
> >
> > Changes not staged for commit:
> > (use "git add/rm <file>..." to update what will be committed)
> > (use "git checkout -- <file>..." to discard changes in working directory)
> >
> > deleted: scripts/remote/__init__.py
> > deleted: scripts/serial/tools/__init__.py
> > deleted: scripts/serial/urlhandler/__init__.py
> >
> > What should actually happen to these files?
>
> Python uses these files to recognize the directory as containing a
> module, so we need to keep them.
They get removed by make distclean, supposedly because they are empty.
What should they contain? Is it ok to put a comment in them to make them
non-empty?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: scripts/remote: make clean leftovers
2016-02-03 7:55 ` Sascha Hauer
@ 2016-02-03 8:58 ` Jan Lübbe
0 siblings, 0 replies; 4+ messages in thread
From: Jan Lübbe @ 2016-02-03 8:58 UTC (permalink / raw)
To: Sascha Hauer; +Cc: barebox
On Mi, 2016-02-03 at 08:55 +0100, Sascha Hauer wrote:
> On Tue, Jan 26, 2016 at 11:49:09AM +0100, Jan Lübbe wrote:
> > On Di, 2016-01-26 at 11:04 +0100, Yegor Yefremov wrote:
> > > After performing make distclean I've discovered following files being removed:
> > >
> > > Changes not staged for commit:
> > > (use "git add/rm <file>..." to update what will be committed)
> > > (use "git checkout -- <file>..." to discard changes in working directory)
> > >
> > > deleted: scripts/remote/__init__.py
> > > deleted: scripts/serial/tools/__init__.py
> > > deleted: scripts/serial/urlhandler/__init__.py
> > >
> > > What should actually happen to these files?
> >
> > Python uses these files to recognize the directory as containing a
> > module, so we need to keep them.
>
> They get removed by make distclean, supposedly because they are empty.
> What should they contain? Is it ok to put a comment in them to make them
> non-empty?
Yes, just add a short comment documenting that they need to exist.
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-02-03 8:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-26 10:04 scripts/remote: make clean leftovers Yegor Yefremov
2016-01-26 10:49 ` Jan Lübbe
2016-02-03 7:55 ` Sascha Hauer
2016-02-03 8:58 ` Jan Lübbe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox