From: Philipp Zabel <p.zabel@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Markus Niebel <Markus.Niebel@tqs.de>
Subject: [PATCH 6/6] net: phy: micrel: errata for KSZ9031
Date: Tue, 2 Feb 2016 12:17:35 +0100 [thread overview]
Message-ID: <1454411855-4839-6-git-send-email-p.zabel@pengutronix.de> (raw)
In-Reply-To: <1454411855-4839-1-git-send-email-p.zabel@pengutronix.de>
The KSZ9031 erratum #2 stats:
The 125MHz reference clock (CLK125_NDO pin) output
has duty cycle variation when the KSZ9031 links up in
1000Base-T Slave mode, resulting in wide variation on
the falling clock edge.
The recommended workaround is to either only use the rising edge of
the CLK125_NDO output for PLL locking, or to
Set KSZ9031 to always link up in 1000Base-T Master mode
by setting register 9h, bits [12:11] to '11'.
Since we can't guarantee the former, this patch does the latter.
Original patch by Markus Niebel <Markus.Niebel@tqs.de>.
Signed-off-by: Markus Niebel <Markus.Niebel@tqs.de>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/net/phy/micrel.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index e8a566d..5227dfb 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -220,6 +220,7 @@ static int ksz9031_config_init(struct phy_device *phydev)
"txd2-skew-ps", "txd3-skew-ps"
};
static const char *control_skews[2] = {"txen-skew-ps", "rxdv-skew-ps"};
+ int rc;
if (!of_node && dev->parent->device_node)
of_node = dev->parent->device_node;
@@ -242,6 +243,14 @@ static int ksz9031_config_init(struct phy_device *phydev)
tx_data_skews, 4);
}
+ rc = phy_read(phydev, MII_CTRL1000);
+ if (rc >= 0) {
+ u16 val = rc;
+ /* Enable master mode, config & prefer master */
+ val |= (CTL1000_ENABLE_MASTER | CTL1000_AS_MASTER);
+ phy_write(phydev, MII_CTRL1000, val);
+ }
+
return ksz9031_center_flp_timing(phydev);
}
--
2.7.0.rc3
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2016-02-02 11:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 11:17 [PATCH 1/6] net: phy: micrel: Staticise ksz8873mll_read_status() Philipp Zabel
2016-02-02 11:17 ` [PATCH 2/6] net: phy: micrel: use BIT macro Philipp Zabel
2016-02-02 11:17 ` [PATCH 3/6] net: phy: micrel: Be more const correct Philipp Zabel
2016-02-02 11:17 ` [PATCH 4/6] net: phy: micrel: Center FLP timing at 16ms Philipp Zabel
2016-02-02 11:17 ` [PATCH 5/6] net: phy: micrel: Add workaround for bad autoneg Philipp Zabel
2016-02-02 11:17 ` Philipp Zabel [this message]
2016-02-02 14:42 ` [PATCH 6/6] net: phy: micrel: errata for KSZ9031 Philipp Zabel
2016-02-03 7:39 ` [PATCH 1/6] net: phy: micrel: Staticise ksz8873mll_read_status() Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454411855-4839-6-git-send-email-p.zabel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=Markus.Niebel@tqs.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox